Issue 117600043: code review 117600043: undo CL 95760043 / b2131d729e52

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 117600043: code review 117600043: undo CL 95760043 / b2131d729e52 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by bradfitz

Modified:
9 years, 11 months ago

Reviewers:
ruiu

CC:
ruiu, golang-codereviews, mpl

Visibility:
Public.

Description

undo CL 95760043 / b2131d729e52 Breaks Camlistore by introducing a datarace. See comments on https://codereview.appspot.com/95760043/ for details. I'll add a new test to lock-in the current behavior in a subsequent CL. I don't think Camlistore is particularly unique here: it's doing the obvious thing to stream a multipart body to a server using a goroutine feeding the multipart writer. ««« original CL description mime/multipart: delay reading random source If a user sets his/her own boundary string with SetBoundary, we don't need to call randomBoundary at all. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/95760043 »»»

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	src/pkg/mime/multipart/writer.go	View		4 chunks	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello ruiu@google.com (cc: golang-codereviews@googlegroups.com, mathieu.lonjaret@gmail.com), I'd like you to review this change to https://go.googlecode.com/hg/

9 years, 11 months ago (2014-08-05 18:27:43 UTC) #1

bradfitz

9 years, 11 months ago (2014-08-05 18:36:49 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d664f6385548 ***

undo CL 95760043 / b2131d729e52

Breaks Camlistore by introducing a datarace. See comments on
https://codereview.appspot.com/95760043/ for details.

I'll add a new test to lock-in the current behavior in a
subsequent CL.

I don't think Camlistore is particularly unique here: it's doing
the obvious thing to stream a multipart body to a server
using a goroutine feeding the multipart writer.

««« original CL description
mime/multipart: delay reading random source

If a user sets his/her own boundary string with SetBoundary,
we don't need to call randomBoundary at all.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/95760043
»»»

LGTM=ruiu
R=ruiu
CC=golang-codereviews, mathieu.lonjaret
https://codereview.appspot.com/117600043

Expand All Messages | Collapse All Messages