code review 117580043: runtime: remove mal/malloc/FlagNoGC/FlagNoInvokeGC

runtime: remove mal/malloc/FlagNoGC/FlagNoInvokeGC
FlagNoGC is unused now.
FlagNoInvokeGC is unneeded as we don't invoke GC
on g0 and when holding locks anyway.
mal/malloc have very few uses and you never remember
the exact set of flags they use and the difference between them.
Moreover, eventually we need to give exact types to all allocations,
something what mal/malloc do not support.

[dvyukov, 2014-08-05 15:18:03]

Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rsc@golang.org),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[khr, 2014-08-06 20:10:26]

On 2014/08/05 15:18:03, dvyukov wrote:
> Hello mailto:golang-codereviews@googlegroups.com (cc: mailto:khr@golang.org,
mailto:rsc@golang.org),
> 
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/

LGTM.

[dvyukov, 2014-08-07 09:04:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=54f358ebd4d6 ***

runtime: remove mal/malloc/FlagNoGC/FlagNoInvokeGC
FlagNoGC is unused now.
FlagNoInvokeGC is unneeded as we don't invoke GC
on g0 and when holding locks anyway.
mal/malloc have very few uses and you never remember
the exact set of flags they use and the difference between them.
Moreover, eventually we need to give exact types to all allocations,
something what mal/malloc do not support.

LGTM=khr
R=golang-codereviews, khr
CC=golang-codereviews, rsc
https://codereview.appspot.com/117580043

[gobot, 2014-08-07 09:17:11]

This CL appears to have broken the windows-amd64 builder.
See http://build.golang.org/log/95989b5d0387191ec2e6fd1acd7b57898b7f9101

[dave_cheney.net, 2014-08-07 09:18:06]

Yup, confirmed.

# Building compilers and Go bootstrap tool.
c:\gobuilder\windows-amd64-54f358ebd4d6\go\src\pkg\runtime\callback_windows.c:63
function args not checked: runtime.mal
c:\gobuilder\windows-amd64-54f358ebd4d6\go\src\pkg\runtime\callback_windows.c:63
incompatible types: "IND STRUCT WinCallbackContext" and "INT" for op
"AS"
warning:
c:\gobuilder\windows-amd64-54f358ebd4d6\go\src\pkg\runtime\callback_windows.c:25
used and not set: c

On Thu, Aug 7, 2014 at 7:17 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the windows-amd64 builder.
> See http://build.golang.org/log/95989b5d0387191ec2e6fd1acd7b57898b7f9101
>
>
> https://codereview.appspot.com/117580043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[dvyukov, 2014-08-07 09:19:30]

i am on it

On Thu, Aug 7, 2014 at 1:18 PM, Dave Cheney <dave@cheney.net> wrote:
> Yup, confirmed.
>
> # Building compilers and Go bootstrap tool.
>
c:\gobuilder\windows-amd64-54f358ebd4d6\go\src\pkg\runtime\callback_windows.c:63
> function args not checked: runtime.mal
>
c:\gobuilder\windows-amd64-54f358ebd4d6\go\src\pkg\runtime\callback_windows.c:63
> incompatible types: "IND STRUCT WinCallbackContext" and "INT" for op
> "AS"
> warning:
c:\gobuilder\windows-amd64-54f358ebd4d6\go\src\pkg\runtime\callback_windows.c:25
> used and not set: c
>
> On Thu, Aug 7, 2014 at 7:17 PM,  <gobot@golang.org> wrote:
>> This CL appears to have broken the windows-amd64 builder.
>> See http://build.golang.org/log/95989b5d0387191ec2e6fd1acd7b57898b7f9101
>>
>>
>> https://codereview.appspot.com/117580043/
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.