Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

Issue 117520043: code review 117520043: encoding/gob: save a call to userType (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by r
Modified:
7 years, 2 months ago
Reviewers:
ruiu, crawshaw
CC:
golang-codereviews, crawshaw, ruiu
Visibility:
Public.

Description

encoding/gob: save a call to userType Avoid some pressure on the global mutex by lifting the call to userType out of the closure. TOTH to Matt Harden.

Patch Set 1 #

Patch Set 2 : diff -r 71a2dfec0640 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/pkg/encoding/gob/decode.go View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
7 years, 2 months ago (2014-08-03 21:34:56 UTC) #1
crawshaw
LGTM
7 years, 2 months ago (2014-08-03 21:49:09 UTC) #2
ruiu
LGTM
7 years, 2 months ago (2014-08-03 21:49:34 UTC) #3
r
7 years, 2 months ago (2014-08-03 22:15:04 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=6b696a34e0af ***

encoding/gob: save a call to userType
Avoid some pressure on the global mutex by lifting the call to userType
out of the closure.
TOTH to Matt Harden.

LGTM=crawshaw, ruiu
R=golang-codereviews, crawshaw, ruiu
CC=golang-codereviews
https://codereview.appspot.com/117520043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b