Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(98)

Issue 117330044: code review 117330044: runtime: fix freebsd build. Assignment is int32* on 32 bit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by khr
Modified:
10 years, 7 months ago
Reviewers:
gobot, dave, bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

runtime: fix freebsd build. Assignment is int32* on 32 bit machines and int64* on 64 bit machines.

Patch Set 1 #

Patch Set 2 : diff -r 577f0018670e https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r 577f0018670e https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r 577f0018670e https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/runtime/os_freebsd.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
khr
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
10 years, 7 months ago (2014-07-30 16:13:45 UTC) #1
bradfitz
LGTM On Jul 30, 2014 9:13 AM, <khr@golang.org> wrote: > Reviewers: golang-codereviews, > > Message: ...
10 years, 7 months ago (2014-07-30 16:16:35 UTC) #2
khr
*** Submitted as https://code.google.com/p/go/source/detail?r=ad109b6a9417 *** runtime: fix freebsd build. Assignment is int32* on 32 bit ...
10 years, 7 months ago (2014-07-30 16:18:03 UTC) #3
gobot
This CL appears to have broken the darwin-386-cheney builder. See http://build.golang.org/log/3a24bdbbf99be17f710ee548377c73282da612ef
10 years, 7 months ago (2014-07-30 16:43:18 UTC) #4
dave_cheney.net
10 years, 7 months ago (2014-07-30 21:55:30 UTC) #5
Not really,

ok  	cmd/fix	0.032s
--- FAIL: TestRepoRootForImportPath (95.75s)
	vcs_test.go:114: RepoRootForImport("code.google.com/p/go"): Get
https://code.google.com/p/go/source/checkout?repo=: dial tcp
150.101.161.152:443: i/o timeout
FAIL
FAIL	cmd/go	95.877s



On Thu, Jul 31, 2014 at 2:43 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the darwin-386-cheney builder.
> See http://build.golang.org/log/3a24bdbbf99be17f710ee548377c73282da612ef
>
>
> https://codereview.appspot.com/117330044/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b