Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(439)

Issue 117280043: code review 117280043: debug/dwarf: fix Reader panic on DW_TAG_unspecified_type

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by dparker
Modified:
9 years, 9 months ago
Reviewers:
r, rsc, bradfitz
CC:
golang-codereviews, bradfitz, iant, rsc
Visibility:
Public.

Description

debug/dwarf: fix Reader panic on DW_TAG_unspecified_type The linker currently produces the DWARF 3 DW_TAG_unspecified_type tag, however the Reader in debug/dwarf will panic whenever that tag is encountered. Fixes issue 8437.

Patch Set 1 #

Patch Set 2 : diff -r ba125b11fd2d https://code.google.com/p/go #

Patch Set 3 : diff -r ba125b11fd2d https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r ba125b11fd2d https://code.google.com/p/go #

Patch Set 5 : diff -r ba125b11fd2d https://code.google.com/p/go #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/pkg/debug/dwarf/type.go View 2 chunks +14 lines, -0 lines 2 comments Download

Messages

Total messages: 12
dparker
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 9 months ago (2014-07-28 20:14:06 UTC) #1
bradfitz
R=iant But my non-dwarf-specific comment: no test? On Mon, Jul 28, 2014 at 1:14 PM, ...
9 years, 9 months ago (2014-07-31 17:40:15 UTC) #2
dparker
On 2014/07/31 17:40:15, bradfitz wrote: > R=iant > > But my non-dwarf-specific comment: no test? ...
9 years, 9 months ago (2014-07-31 17:54:27 UTC) #3
iant
https://codereview.appspot.com/117280043/diff/30002/src/pkg/debug/dwarf/type.go File src/pkg/debug/dwarf/type.go (right): https://codereview.appspot.com/117280043/diff/30002/src/pkg/debug/dwarf/type.go#newcode91 src/pkg/debug/dwarf/type.go:91: type UnspecifiedType struct { This new exported type needs ...
9 years, 9 months ago (2014-07-31 22:48:19 UTC) #4
dparker
Hello golang-codereviews@googlegroups.com, bradfitz@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 9 months ago (2014-08-01 14:30:24 UTC) #5
dparker
Hello golang-codereviews@googlegroups.com, bradfitz@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 9 months ago (2014-08-01 14:31:42 UTC) #6
rsc
LGTM
9 years, 9 months ago (2014-08-06 18:34:41 UTC) #7
rsc
Please complete a CLA as described at golang.org/doc/contribute.html#copyright Thanks.
9 years, 9 months ago (2014-08-06 18:35:39 UTC) #8
dparker
On 2014/08/06 18:35:39, rsc wrote: > Please complete a CLA as described at golang.org/doc/contribute.html#copyright > ...
9 years, 9 months ago (2014-08-06 18:50:14 UTC) #9
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=6c719039ae2e *** debug/dwarf: fix Reader panic on DW_TAG_unspecified_type The linker currently produces ...
9 years, 9 months ago (2014-08-06 19:11:39 UTC) #10
r
https://codereview.appspot.com/117280043/diff/60001/src/pkg/debug/dwarf/type.go File src/pkg/debug/dwarf/type.go (right): https://codereview.appspot.com/117280043/diff/60001/src/pkg/debug/dwarf/type.go#newcode91 src/pkg/debug/dwarf/type.go:91: // A UnspecifiedType represents implicit, unknown, ambiguous or nonexistent ...
9 years, 9 months ago (2014-08-06 20:25:14 UTC) #11
r
9 years, 9 months ago (2014-08-06 20:35:45 UTC) #12
https://codereview.appspot.com/117280043/diff/60001/src/pkg/debug/dwarf/type.go
File src/pkg/debug/dwarf/type.go (right):

https://codereview.appspot.com/117280043/diff/60001/src/pkg/debug/dwarf/type....
src/pkg/debug/dwarf/type.go:91: // A UnspecifiedType represents implicit,
unknown, ambiguous or nonexistent type.
s/implicit/an implicit/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b