Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(664)

Issue 117250044: code review 117250044: time: make it clearer that the reference time is the re... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by r
Modified:
10 years, 9 months ago
Reviewers:
dave, josharian
CC:
golang-codereviews, josharian, dave_cheney.net
Visibility:
Public.

Description

time: make it clearer that the reference time is the reference time. Because the reference time is the reference time but beginners seem to think otherwise, make it clearer you can't choose the reference time.

Patch Set 1 #

Patch Set 2 : diff -r 2795b120d1a2 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/pkg/time/format.go View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 9 months ago (2014-07-28 18:04:27 UTC) #1
josharian
LGTM
10 years, 9 months ago (2014-07-28 18:05:42 UTC) #2
dave_cheney.net
LGTM. Let this be the end of the matter. On 29 Jul 2014 04:05, <josharian@gmail.com> ...
10 years, 9 months ago (2014-07-28 23:03:32 UTC) #3
r
10 years, 9 months ago (2014-07-29 00:24:43 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=7e9ede8077ba ***

time: make it clearer that the reference time is the reference time.
Because the reference time is the reference time but beginners seem
to think otherwise, make it clearer you can't choose the reference time.

LGTM=josharian, dave
R=golang-codereviews, josharian, dave
CC=golang-codereviews
https://codereview.appspot.com/117250044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b