Issue 117060043: code review 117060043: misc/pprof: support web profiles on windows/MinGW

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 117060043: code review 117060043: misc/pprof: support web profiles on windows/MinGW (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by chai2010

Modified:
10 years, 9 months ago

Reviewers:
gobot, bradfitz

CC:
golang-codereviews, bradfitz

Visibility:
Public.

Description

misc/pprof: support web profiles on windows/MinGW

Patch Set 2 : diff -r da790858e12c https://code.google.com/p/go/ #

Patch Set 3 : diff -r da790858e12c https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 6a4157362cfd https://code.google.com/p/go/ #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	misc/pprof	View		1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

chai2010

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

10 years, 9 months ago (2014-07-22 07:03:04 UTC) #1

bradfitz

https://codereview.appspot.com/117060043/diff/20002/misc/pprof File misc/pprof (right): https://codereview.appspot.com/117060043/diff/20002/misc/pprof#newcode739 misc/pprof:739: if (`uname` =~ /MINGW/) { running uname three times ...

10 years, 9 months ago (2014-07-22 16:32:33 UTC) #2

chai2010

PTAL https://codereview.appspot.com/117060043/diff/20002/misc/pprof File misc/pprof (right): https://codereview.appspot.com/117060043/diff/20002/misc/pprof#newcode739 misc/pprof:739: if (`uname` =~ /MINGW/) { On 2014/07/22 16:32:33, ...

10 years, 9 months ago (2014-07-23 01:01:20 UTC) #3

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=2ef3b43a0d0d *** misc/pprof: support web profiles on windows/MinGW LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews ...

10 years, 9 months ago (2014-07-23 17:41:44 UTC) #5

gobot

10 years, 9 months ago (2014-07-23 18:18:16 UTC) #6

This CL appears to have broken the darwin-386 builder.
See http://build.golang.org/log/1e0649475c94497e02a1e31ee8a3ad22241e1238

Expand All Messages | Collapse All Messages