code review 11705043: math/rand: mention Seed in overview, add another top-le...

math/rand: mention Seed in overview, add another top-level example

Fixes issue 5937.

[adg, 2013-07-23 03:51:07]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[aam, 2013-07-23 04:15:01]

https://codereview.appspot.com/11705043/diff/1/src/pkg/math/rand/example_test.go
File src/pkg/math/rand/example_test.go (right):

https://codereview.appspot.com/11705043/diff/1/src/pkg/math/rand/example_test...
src/pkg/math/rand/example_test.go:14: // These tests serve as an example but
also makes sure we don't change
singular make.

[adg, 2013-07-23 04:16:58]

Thanks

https://codereview.appspot.com/11705043/diff/1/src/pkg/math/rand/example_test.go
File src/pkg/math/rand/example_test.go (right):

https://codereview.appspot.com/11705043/diff/1/src/pkg/math/rand/example_test...
src/pkg/math/rand/example_test.go:14: // These tests serve as an example but
also makes sure we don't change
On 2013/07/23 04:15:01, aam wrote:
> singular make.

Done.

[r, 2013-07-23 05:01:05]

https://codereview.appspot.com/11705043/diff/7001/src/pkg/math/rand/rand.go
File src/pkg/math/rand/rand.go (right):

https://codereview.appspot.com/11705043/diff/7001/src/pkg/math/rand/rand.go#n...
src/pkg/math/rand/rand.go:8: // source that may be seeded with the Seed
function.
Random numbers are generated by a Source. Top-level functions, such as Float64
and Int, use a default shared Source  that produces a deterministic sequence of
values each time a program is run. Use the Seed function to initialize the
global Source if different behavior is required for each run.

and then on the global Int function etc. say

... from the default Source.

[adg, 2013-07-23 05:07:51]

Hello golang-dev@googlegroups.com, mirtchovski@gmail.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2013-07-23 06:06:37]

LGTM

[adg, 2013-07-23 06:07:36]

*** Submitted as https://code.google.com/p/go/source/detail?r=f6a20261d881 ***

math/rand: mention Seed in overview, add another top-level example

Fixes issue 5937.

R=golang-dev, mirtchovski, r
CC=golang-dev
https://codereview.appspot.com/11705043

[remyoudompheng, 2013-07-23 06:12:13]

2013/7/23  <r@golang.org>:
>
> https://codereview.appspot.com/11705043/diff/7001/src/pkg/math/rand/rand.go
> File src/pkg/math/rand/rand.go (right):
>
>
https://codereview.appspot.com/11705043/diff/7001/src/pkg/math/rand/rand.go#n...
> src/pkg/math/rand/rand.go:8: // source that may be seeded with the Seed
> function.
> Random numbers are generated by a Source. Top-level functions, such as
> Float64 and Int, use a default shared Source  that produces a
> deterministic sequence of values each time a program is run. Use the
> Seed function to initialize the global Source if different behavior is
> required for each run.
>
> and then on the global Int function etc. say
>
> ... from the default Source.
>

Should it be mentioned that the "default source" is goroutine-safe?
The only Source factory function is NewSource returning a
non-goroutine safe version.

Rémy.

[adg, 2013-07-23 06:14:21]

It is probably worth mentioning. The assumption throughout the standard
library is "not thread safe unless otherwise specified".


On 23 July 2013 16:12, Rémy Oudompheng <remyoudompheng@gmail.com> wrote:

> 2013/7/23  <r@golang.org>:
> >
> >
> https://codereview.appspot.com/11705043/diff/7001/src/pkg/math/rand/rand.go
> > File src/pkg/math/rand/rand.go (right):
> >
> >
>
https://codereview.appspot.com/11705043/diff/7001/src/pkg/math/rand/rand.go#n...
> > src/pkg/math/rand/rand.go:8: // source that may be seeded with the Seed
> > function.
> > Random numbers are generated by a Source. Top-level functions, such as
> > Float64 and Int, use a default shared Source  that produces a
> > deterministic sequence of values each time a program is run. Use the
> > Seed function to initialize the global Source if different behavior is
> > required for each run.
> >
> > and then on the global Int function etc. say
> >
> > ... from the default Source.
> >
>
> Should it be mentioned that the "default source" is goroutine-safe?
> The only Source factory function is NewSource returning a
> non-goroutine safe version.
>
> Rémy.
>