Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(139)

Issue 117000043: code review 117000043: cmd/ld: mark hostobj sections as containing no pointers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by dvyukov
Modified:
11 years ago
Reviewers:
gobot, rsc, rlh
CC:
golang-codereviews, rlh, rsc, iant, khr
Visibility:
Public.

Description

cmd/ld: mark hostobj sections as containing no pointers Currently they are scanned conservatively. But there is no reason to scan them. C world must not contain pointers into Go heap. Moreover, we don't have enough information to emit write barriers nor update pointers there in future. The immediate need is that it breaks the new GC because these are weird symbols as if with pointers but not necessary pointer aligned.

Patch Set 1 #

Patch Set 2 : diff -r d5c083552430 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r d5c083552430 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r da790858e12c https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/cmd/ld/ldelf.c View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/ld/ldmacho.c View 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/ld/ldpe.c View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9
dvyukov
Hello golang-codereviews@googlegroups.com (cc: iant@golang.org, khr@golang.org, rlh@golang.org, rsc@golang.org), I'd like you to review this change to ...
11 years ago (2014-07-21 09:19:09 UTC) #1
rlh
On 2014/07/21 09:19:09, dvyukov wrote: > Hello mailto:golang-codereviews@googlegroups.com (cc: mailto:iant@golang.org, mailto:khr@golang.org, > mailto:rlh@golang.org, mailto:rsc@golang.org), > ...
11 years ago (2014-07-21 12:14:56 UTC) #2
dvyukov
On 2014/07/21 12:14:56, rlh wrote: > On 2014/07/21 09:19:09, dvyukov wrote: > > Hello mailto:golang-codereviews@googlegroups.com ...
11 years ago (2014-07-21 12:18:10 UTC) #3
rlh
Do these sources of imprecise pointers have the same problem? If so how do we ...
11 years ago (2014-07-21 12:49:25 UTC) #4
dvyukov
On Mon, Jul 21, 2014 at 4:49 PM, Rick Hudson <rlh@golang.org> wrote: > Do these ...
11 years ago (2014-07-21 12:55:02 UTC) #5
rsc
LGTM
11 years ago (2014-07-22 03:42:53 UTC) #6
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=da1002b78b19 *** cmd/ld: mark hostobj sections as containing no pointers Currently they ...
11 years ago (2014-07-22 08:10:25 UTC) #7
gobot
This CL appears to have broken the windows-amd64 builder. See http://build.golang.org/log/d4352f59ddaff6103b292c3068d0c143412b22b4
11 years ago (2014-07-22 08:23:15 UTC) #8
rlh
11 years ago (2014-07-22 14:35:30 UTC) #9
LGTM


On Tue, Jul 22, 2014 at 4:23 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the windows-amd64 builder.
> See http://build.golang.org/log/d4352f59ddaff6103b292c3068d0c143412b22b4
>
> https://codereview.appspot.com/117000043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b