Issue 11696045: Sets up sharing links to use jujucharms.com

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11696045: Sets up sharing links to use jujucharms.com

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by j.c.sackett

Modified:
10 years, 9 months ago

Reviewers:
rharding, mp+176533, jeff.pihach

Visibility:
Public.

Description

Sets up sharing links to use jujucharms.com https://code.launchpad.net/~jcsackett/juju-gui/sharing-uses-jujucharms/+merge/176533 (do not edit description out of merge proposal)

Patch Set 2 : Sets up sharing links to use jujucharms.com #

Patch Set 3 : Sets up sharing links to use jujucharms.com #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	app/subapps/browser/views/charm.js	View	1 2	2 chunks	+6 lines, -10 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM with minor q https://codereview.appspot.com/11696045/diff/1/app/subapps/browser/views/charm.js File app/subapps/browser/views/charm.js (right): https://codereview.appspot.com/11696045/diff/1/app/subapps/browser/views/charm.js#newcode681 app/subapps/browser/views/charm.js:681: var link = 'http://jujucharms.com/' + ...

10 years, 9 months ago (2013-07-24 00:05:59 UTC) #2

j.c.sackett

On 2013/07/24 00:05:59, jeff.pihach wrote: > LGTM with minor q > > https://codereview.appspot.com/11696045/diff/1/app/subapps/browser/views/charm.js > File ...

10 years, 9 months ago (2013-07-24 00:26:29 UTC) #3

rharding

LGTM I think it'd be nice if the common repeated domain name were pulled into ...

10 years, 9 months ago (2013-07-24 14:08:32 UTC) #5

j.c.sackett

10 years, 9 months ago (2013-07-24 16:53:50 UTC) #6

*** Submitted:

Sets up sharing links to use jujucharms.com

R=jeff.pihach, rharding
CC=
https://codereview.appspot.com/11696045

Expand All Messages | Collapse All Messages