Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(862)

Issue 116950043: code review 116950043: runtime: simplify code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by dvyukov
Modified:
6 years, 4 months ago
Reviewers:
gobot, khr
CC:
golang-codereviews, dfc, khr, rsc
Visibility:
Public.

Description

runtime: simplify code

Patch Set 1 #

Patch Set 2 : diff -r e1d0077340e8 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r e1d0077340e8 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r e5fa01e2f333 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M src/pkg/runtime/mgc0.c View 2 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 7
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
6 years, 4 months ago (2014-07-20 11:40:56 UTC) #1
dfc
Is there any measurable performance delta for this patch? runtime.persistentalloc appears to do the same ...
6 years, 4 months ago (2014-07-21 10:06:37 UTC) #2
dvyukov
No, there is no. That code path is executed only a handful of times during ...
6 years, 4 months ago (2014-07-21 10:16:30 UTC) #3
dfc
Fair enough. Thanks for the confirmation. On Mon, Jul 21, 2014 at 8:16 PM, Dmitry ...
6 years, 4 months ago (2014-07-21 10:21:03 UTC) #4
khr
LGTM.
6 years, 4 months ago (2014-07-21 19:47:24 UTC) #5
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=e29388c4dad0 *** runtime: simplify code LGTM=khr R=golang-codereviews, dave, khr CC=golang-codereviews, rsc https://codereview.appspot.com/116950043
6 years, 4 months ago (2014-07-21 21:56:05 UTC) #6
gobot
6 years, 4 months ago (2014-07-21 22:23:49 UTC) #7
Message was sent while issue was closed.
This CL appears to have broken the nacl-arm builder.
See http://build.golang.org/log/6dac54b5cb4d1abac23959e70e4bc050d477d1ec
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b