code review 116950043: runtime: simplify code

runtime: simplify code

[dvyukov, 2014-07-20 11:40:56]

Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rsc@golang.org),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[dfc, 2014-07-21 10:06:37]

Is there any measurable performance delta for this patch?
runtime.persistentalloc appears to do the same thing as the and coded sysalloc
routine in getempty but there is more bookkeeping in the former.

[dvyukov, 2014-07-21 10:16:30]

No, there is no. That code path is executed only a handful of times
during initial GCs.

On Mon, Jul 21, 2014 at 2:06 PM,  <dave@cheney.net> wrote:
> Is there any measurable performance delta for this patch?
> runtime.persistentalloc appears to do the same thing as the and coded
> sysalloc routine in getempty but there is more bookkeeping in the
> former.
>
> https://codereview.appspot.com/116950043/

[dfc, 2014-07-21 10:21:03]

Fair enough. Thanks for the confirmation.


On Mon, Jul 21, 2014 at 8:16 PM, Dmitry Vyukov <dvyukov@google.com> wrote:

> No, there is no. That code path is executed only a handful of times
> during initial GCs.
>
> On Mon, Jul 21, 2014 at 2:06 PM,  <dave@cheney.net> wrote:
> > Is there any measurable performance delta for this patch?
> > runtime.persistentalloc appears to do the same thing as the and coded
> > sysalloc routine in getempty but there is more bookkeeping in the
> > former.
> >
> > https://codereview.appspot.com/116950043/
>

[khr, 2014-07-21 19:47:24]

LGTM.

[dvyukov, 2014-07-21 21:56:05]

*** Submitted as https://code.google.com/p/go/source/detail?r=e29388c4dad0 ***

runtime: simplify code

LGTM=khr
R=golang-codereviews, dave, khr
CC=golang-codereviews, rsc
https://codereview.appspot.com/116950043

[gobot, 2014-07-21 22:23:49]

This CL appears to have broken the nacl-arm builder.
See http://build.golang.org/log/6dac54b5cb4d1abac23959e70e4bc050d477d1ec