code review 11691044: net: make use of noDeadline instead of time.Time{}

net: make use of noDeadline instead of time.Time{}

[mikio, 2013-07-23 01:02:02]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-07-23 01:04:50]

LGTM

You can remove the comment "// no deadline set" now.



On Mon, Jul 22, 2013 at 6:02 PM, <mikioh.mikioh@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net: make use of noDeadline instead of time.Time{}
>
> Please review this at
https://codereview.appspot.**com/11691044/<https://codereview.appspot.com/116...
>
> Affected files:
>   M src/pkg/net/dnsclient_unix.go
>   M src/pkg/net/fd_posix_test.go
>   M src/pkg/net/sock_posix.go
>
>
> Index: src/pkg/net/dnsclient_unix.go
> ==============================**==============================**=======
> --- a/src/pkg/net/dnsclient_unix.**go
> +++ b/src/pkg/net/dnsclient_unix.**go
> @@ -46,7 +46,7 @@
>                 }
>
>                 if cfg.timeout == 0 {
> -                       c.SetReadDeadline(time.Time{})
> +                       c.SetReadDeadline(noDeadline)
>                 } else {
>                        
c.SetReadDeadline(time.Now().**Add(time.Duration(cfg.timeout)
> * time.Second))
>                 }
> Index: src/pkg/net/fd_posix_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/fd_posix_test.go
> +++ b/src/pkg/net/fd_posix_test.go
> @@ -15,7 +15,7 @@
>         input    time.Time
>         expected int64
>  }{
> -       {time.Time{}, 0},
> +       {noDeadline, 0},
>         {time.Date(2009, 11, 10, 23, 00, 00, 00, time.UTC),
> 1257894000000000000}, // 2009-11-10 23:00:00 +0000 UTC
>  }
>
> @@ -42,7 +42,7 @@
>         // the start of TestDeadlineExpired
>         {time.Now().Add(5 * time.Minute), false},
>         {time.Now().Add(-5 * time.Minute), true},
> -       {time.Time{}, false}, // no deadline set
> +       {noDeadline, false}, // no deadline set
>  }
>
>  func TestDeadlineExpired(t *testing.T) {
> Index: src/pkg/net/sock_posix.go
> ==============================**==============================**=======
> --- a/src/pkg/net/sock_posix.go
> +++ b/src/pkg/net/sock_posix.go
> @@ -63,7 +63,7 @@
>                 }
>                 fd.isConnected = true
>                 if !deadline.IsZero() {
> -                       setWriteDeadline(fd, time.Time{})
> +                       setWriteDeadline(fd, noDeadline)
>                 }
>         }
>
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[mikio, 2013-07-23 01:13:19]

On Tue, Jul 23, 2013 at 10:04 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> You can remove the comment "// no deadline set" now.

thx.

[mikio, 2013-07-23 01:14:07]

*** Submitted as https://code.google.com/p/go/source/detail?r=677f1dc462af ***

net: make use of noDeadline instead of time.Time{}

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/11691044