Issue 1169044: merge together social/gadgets rpc/rest endpoints

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1169044: merge together social/gadgets rpc/rest endpoints

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by Paul Lindner

Modified:
13 years, 11 months ago

Reviewers:
shindig.remailer

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Finish up all changes to make multibinding work, clean up web.xml #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -97 lines)			Patch
M	config/container.js	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java	View	1	2 chunks	+8 lines, -7 lines	0 comments	Download
	java/server/src/main/webapp/WEB-INF/web.xml	View	1	4 chunks	+11 lines, -40 lines	0 comments	Download
M	java/server/src/test/java/org/apache/shindig/server/JettyLauncher.java	View	1	4 chunks	+24 lines, -24 lines	0 comments	Download
M	java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java	View	1	4 chunks	+10 lines, -5 lines	0 comments	Download
M	java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java	View		3 chunks	+7 lines, -4 lines	0 comments	Download
M	java/social-api/src/main/java/org/apache/shindig/social/sample/SampleModule.java	View		4 chunks	+6 lines, -12 lines	0 comments	Download
M	java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/AbstractLargeRestfulTests.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Paul Lindner

13 years, 11 months ago (2010-05-12 20:41:01 UTC) #3

Here's an updated version of the patch.

Basically this change unifies the rpc/rest handlers for gadgets/social and
also makes it much easier to add a new Handler.  See the changes in
SampleModule.java to see what I mean.

You can still run separated gadget/social APIs if you want, it's just not
the default anymore.  Changing back to the old model can be done with a
container.js change.

Also, does anyone still use JettyLauncher.java anymore?  It appears that
it's not referenced anymore and is largely a cut-and-paste of
EndToEndServer.java...

On Wed, May 12, 2010 at 1:35 PM, <lindner@inuus.com> wrote:

> http://codereview.appspot.com/1169044/show
>

Expand All Messages | Collapse All Messages