Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(387)

Issue 11681043: code review 11681043: runtime: introduce notetsleepg function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by dvyukov
Modified:
9 years, 2 months ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

runtime: introduce notetsleepg function notetsleepg is the same as notetsleep, but is called on user g. It includes entersyscall/exitsyscall and will help to avoid split stack functions in syscall status.

Patch Set 1 #

Patch Set 2 : diff -r 86a2e482982f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 86a2e482982f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 2eaab1510c3f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 2eaab1510c3f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r f454ddfc8968 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r f454ddfc8968 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -15 lines) Patch
M src/pkg/runtime/cpuprof.c View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M src/pkg/runtime/lock_futex.c View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M src/pkg/runtime/lock_sema.c View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M src/pkg/runtime/mheap.c View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/runtime/sigqueue.goc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M src/pkg/runtime/time.goc View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 2 months ago (2013-07-22 17:53:05 UTC) #1
rsc
LGTM
9 years, 2 months ago (2013-07-22 18:31:46 UTC) #2
dvyukov
9 years, 2 months ago (2013-07-22 19:02:32 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=3d177aef8dd3 ***

runtime: introduce notetsleepg function
notetsleepg is the same as notetsleep, but is called on user g.
It includes entersyscall/exitsyscall and will help to avoid
split stack functions in syscall status.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/11681043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b