code review 11679043: runtime: reduce amount of stack space used by nosplit c...

runtime: allow stack split in body of closechan
This gives more space during the call to runtime.lock.

[dvyukov, 2013-07-22 16:12:32]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[rsc, 2013-07-22 16:17:12]

What does this have to do with runtime.lock?

[dvyukov, 2013-07-22 16:21:37]

On Mon, Jul 22, 2013 at 8:17 PM,  <rsc@golang.org> wrote:
> What does this have to do with runtime.lock?

When I marked runtime.lock as nosplit, it said:

runtime.closechan: nosplit stack overflow
120 assumed on entry to runtime.closechan
72 after runtime.closechan uses 48
64 on entry to runtime.lock
24 after runtime.lock uses 40
16 on entry to runtime.futexsleep
-56 after runtime.futexsleep uses 72

[rsc, 2013-07-22 16:43:08]

LGTM

Please make the CL description say:

runtime: allow stack split in body of closechan

This gives more space during the call to runtime.lock.

[dvyukov, 2013-07-22 16:47:43]

*** Submitted as https://code.google.com/p/go/source/detail?r=2eaab1510c3f ***

runtime: allow stack split in body of closechan
This gives more space during the call to runtime.lock.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/11679043