Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(76)

Issue 11679043: code review 11679043: runtime: reduce amount of stack space used by nosplit c... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by dvyukov
Modified:
9 years, 2 months ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

runtime: allow stack split in body of closechan This gives more space during the call to runtime.lock.

Patch Set 1 #

Patch Set 2 : diff -r 86a2e482982f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 86a2e482982f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 86a2e482982f https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M src/pkg/runtime/chan.c View 1 3 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 2 months ago (2013-07-22 16:12:32 UTC) #1
rsc
What does this have to do with runtime.lock?
9 years, 2 months ago (2013-07-22 16:17:12 UTC) #2
dvyukov
On Mon, Jul 22, 2013 at 8:17 PM, <rsc@golang.org> wrote: > What does this have ...
9 years, 2 months ago (2013-07-22 16:21:37 UTC) #3
rsc
LGTM Please make the CL description say: runtime: allow stack split in body of closechan ...
9 years, 2 months ago (2013-07-22 16:43:08 UTC) #4
dvyukov
9 years, 2 months ago (2013-07-22 16:47:43 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=2eaab1510c3f ***

runtime: allow stack split in body of closechan
This gives more space during the call to runtime.lock.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/11679043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b