Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8380)

Issue 11677043: code review 11677043: misc/cgo/test: add test for cgo callbacks with differen... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by dvyukov
Modified:
9 years, 4 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

misc/cgo/test: add test for cgo callbacks with different amount of stack space available

Patch Set 1 #

Patch Set 2 : diff -r e6a6dc0d9c22 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r e6a6dc0d9c22 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 86a2e482982f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 86a2e482982f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 2eaab1510c3f https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1496 lines, -0 lines) Patch
M misc/cgo/test/callback.go View 1 2 3 2 chunks +1488 lines, -0 lines 0 comments Download
M misc/cgo/test/callback_c.c View 1 1 chunk +7 lines, -0 lines 0 comments Download
M misc/cgo/test/cgo_test.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 4 months ago (2013-07-22 16:09:40 UTC) #1
bradfitz
LGTM
9 years, 4 months ago (2013-07-22 17:34:45 UTC) #2
dvyukov
9 years, 4 months ago (2013-07-22 17:53:33 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=f454ddfc8968 ***

misc/cgo/test: add test for cgo callbacks with different amount of stack space
available

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/11677043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b