Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2283)

Issue 11674045: state/api/params: redefine ErrorResults

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by rog
Modified:
10 years, 9 months ago
Reviewers:
mue, dimitern, mp+176744
Visibility:
Public.

Description

state/api/params: redefine ErrorResults This is future-proofing - it potentially allows us to change an API call from returning some no data to returning some data, in a backwardly compatible way. It means that the standard result of a bulk API call is {Results: [{Error: {error contents}, other returned data}, ...]} whether it returns some data from the result of each element in the bulk operation or not. https://code.launchpad.net/~rogpeppe/juju-core/350-error-results/+merge/176744 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/api/params: redefine ErrorResults #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -83 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/api/deployer/unit.go View 2 chunks +2 lines, -8 lines 0 comments Download
M state/api/machineagent/state.go View 1 chunk +1 line, -4 lines 0 comments Download
M state/api/machiner/machine.go View 2 chunks +2 lines, -14 lines 0 comments Download
M state/api/params/params.go View 1 chunk +21 lines, -4 lines 0 comments Download
M state/apiserver/common/password.go View 2 chunks +3 lines, -3 lines 0 comments Download
M state/apiserver/common/password_test.go View 2 chunks +6 lines, -6 lines 0 comments Download
M state/apiserver/common/remove.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/apiserver/common/remove_test.go View 2 chunks +9 lines, -9 lines 0 comments Download
M state/apiserver/deployer/deployer_test.go View 5 chunks +14 lines, -16 lines 0 comments Download
M state/apiserver/machine/agent_test.go View 1 chunk +4 lines, -4 lines 0 comments Download
M state/apiserver/machine/machiner.go View 4 chunks +4 lines, -4 lines 0 comments Download
M state/apiserver/machine/machiner_test.go View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
10 years, 9 months ago (2013-07-24 17:23:25 UTC) #1
dimitern
Nice, LGTM.
10 years, 9 months ago (2013-07-24 17:25:15 UTC) #2
mue
10 years, 9 months ago (2013-07-24 18:40:37 UTC) #3
LGTM, nice.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b