code review 11674044: net: consolidate listenerBacklog declaration

net: consolidate listenerBacklog declaration

Also adds maxListenerBacklog placeholder for Plan 9.

[mikio, 2013-07-23 13:03:55]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-07-23 16:29:55]

LGTM



On Tue, Jul 23, 2013 at 6:03 AM, <mikioh.mikioh@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net: consolidate listenerBacklog declaration
>
> Also adds maxListenerBacklog placeholder for Plan 9.
>
> Please review this at
https://codereview.appspot.**com/11674044/<https://codereview.appspot.com/116...
>
> Affected files:
>   M src/pkg/net/ipsock_plan9.go
>   M src/pkg/net/net.go
>   A src/pkg/net/sock_plan9.go
>   M src/pkg/net/sock_posix.go
>
>
> Index: src/pkg/net/ipsock_plan9.go
> ==============================**==============================**=======
> --- a/src/pkg/net/ipsock_plan9.go
> +++ b/src/pkg/net/ipsock_plan9.go
> @@ -12,9 +12,6 @@
>         "syscall"
>  )
>
> -// /sys/include/ape/sys/socket.h:**/SOMAXCONN
> -var listenerBacklog = 5
> -
>  // probeIPv6Stack returns two boolean values.  If the first boolean
>  // value is true, kernel supports basic IPv6 functionality.  If the
>  // second boolean value is true, kernel supports IPv6 IPv4-mapping.
> Index: src/pkg/net/net.go
> ==============================**==============================**=======
> --- a/src/pkg/net/net.go
> +++ b/src/pkg/net/net.go
> @@ -259,6 +259,8 @@
>         SetWriteDeadline(t time.Time) error
>  }
>
> +var listenerBacklog = maxListenerBacklog()
> +
>  // A Listener is a generic network listener for stream-oriented protocols.
>  //
>  // Multiple goroutines may invoke methods on a Listener simultaneously.
> Index: src/pkg/net/sock_plan9.go
> ==============================**==============================**=======
> new file mode 100644
> --- /dev/null
> +++ b/src/pkg/net/sock_plan9.go
> @@ -0,0 +1,10 @@
> +// Copyright 2013 The Go Authors.  All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +package net
> +
> +func maxListenerBacklog() int {
> +       // /sys/include/ape/sys/socket.h:**/SOMAXCONN
> +       return 5
> +}
> Index: src/pkg/net/sock_posix.go
> ==============================**==============================**=======
> --- a/src/pkg/net/sock_posix.go
> +++ b/src/pkg/net/sock_posix.go
> @@ -11,8 +11,6 @@
>         "time"
>  )
>
> -var listenerBacklog = maxListenerBacklog()
> -
>  // Generic POSIX socket creation.
>  func socket(net string, f, t, p int, ipv6only bool, ulsa, ursa
> syscall.Sockaddr, deadline time.Time, toAddr func(syscall.Sockaddr) Addr)
> (fd *netFD, err error) {
>         s, err := sysSocket(f, t, p)
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[mikio, 2013-07-23 23:43:15]

*** Submitted as https://code.google.com/p/go/source/detail?r=f76748f48464 ***

net: consolidate listenerBacklog declaration

Also adds maxListenerBacklog placeholder for Plan 9.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/11674044