Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1167)

Issue 116730043: code review 116730043: ogle/debug/dwarf: add SliceType, StringType, MapType (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by r
Modified:
7 years, 4 months ago
Reviewers:
rsc
CC:
rsc
Visibility:
Public.

Description

ogle/debug/dwarf: add SliceType, StringType, MapType These new types make it cleaner to disambiguate DWARF items representing Go types. They were previously just structs with funny names. Depends on 116720043

Patch Set 1 #

Patch Set 2 : diff -r bad9b3a11146 https://code.google.com/p/ogle #

Patch Set 3 : diff -r 4f0a7455f8e0 https://code.google.com/p/ogle #

Patch Set 4 : diff -r 4f0a7455f8e0 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -17 lines) Patch
M debug/dwarf/const.go View 1 2 chunks +13 lines, -0 lines 0 comments Download
M debug/dwarf/type.go View 1 16 chunks +102 lines, -17 lines 0 comments Download

Messages

Total messages: 3
rsc
LGTM
7 years, 4 months ago (2014-07-14 17:10:15 UTC) #1
r
Hello rsc@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 4 months ago (2014-07-14 17:31:41 UTC) #2
r
7 years, 4 months ago (2014-07-14 17:31:45 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=836b304af90d ***

ogle/debug/dwarf: add SliceType, StringType, MapType
These new types make it cleaner to disambiguate DWARF items
representing Go types. They were previously just structs with
funny names.
Depends on 116720043

LGTM=rsc
R=rsc
https://codereview.appspot.com/116730043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b