Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8958)

Issue 11671043: code review 11671043: runtime: clarify comment for m->locked (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by dvyukov
Modified:
9 years, 4 months ago
Reviewers:
r, dsymonds
CC:
golang-dev, r
Visibility:
Public.

Description

runtime: clarify comment for m->locked

Patch Set 1 #

Patch Set 2 : diff -r e6a6dc0d9c22 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r e6a6dc0d9c22 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r e6a6dc0d9c22 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 2

Patch Set 5 : diff -r 5c948e69f885 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M src/pkg/runtime/runtime.h View 1 2 3 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 4 months ago (2013-07-22 11:08:17 UTC) #1
r
LGTM with my version if that's OK https://codereview.appspot.com/11671043/diff/6001/src/pkg/runtime/runtime.h File src/pkg/runtime/runtime.h (right): https://codereview.appspot.com/11671043/diff/6001/src/pkg/runtime/runtime.h#newcode367 src/pkg/runtime/runtime.h:367: // e.g. ...
9 years, 4 months ago (2013-07-22 11:24:58 UTC) #2
r
s/innitialization/initialization/
9 years, 4 months ago (2013-07-22 11:25:13 UTC) #3
dvyukov
PTAL https://codereview.appspot.com/11671043/diff/11001/src/pkg/runtime/runtime.h File src/pkg/runtime/runtime.h (right): https://codereview.appspot.com/11671043/diff/11001/src/pkg/runtime/runtime.h#newcode362 src/pkg/runtime/runtime.h:362: // The m->locked word holds two pieces of ...
9 years, 4 months ago (2013-07-22 11:45:52 UTC) #4
r
LGTM
9 years, 4 months ago (2013-07-22 12:29:43 UTC) #5
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=86a2e482982f *** runtime: clarify comment for m->locked R=golang-dev, r CC=golang-dev https://codereview.appspot.com/11671043
9 years, 4 months ago (2013-07-22 12:37:49 UTC) #6
dsymonds
9 years, 4 months ago (2013-07-23 00:48:59 UTC) #7
Message was sent while issue was closed.
LGTM

Thanks, this is much better.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b