Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 11666046: code review 11666046: [release-branch.go1.1] time: prevent a panic from leavi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by adg
Modified:
9 years, 4 months ago
Reviewers:
dfc
CC:
golang-dev, dfc
Visibility:
Public.

Description

[release-branch.go1.1] time: prevent a panic from leaving the timer mutex held ««« CL 10373047 / 974a69ed9fcf time: prevent a panic from leaving the timer mutex held When deleting a timer, a panic due to nil deref would leave a lock held, possibly leading to a deadlock in a defer. Instead return false on a nil timer. Fixes issue 5745. R=golang-dev, daniel.morsing, dvyukov, rsc, iant CC=golang-dev https://codereview.appspot.com/10373047 Committer: Russ Cox <rsc@golang.org> »»» Update issue 5928

Patch Set 1 #

Patch Set 2 : diff -r 7f7bdef7fc85 https://code.google.com/p/go #

Patch Set 3 : diff -r 7f7bdef7fc85 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M src/pkg/runtime/time.goc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/time/sleep_test.go View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 4 months ago (2013-07-22 08:36:36 UTC) #1
dfc
LGTM. On 22/07/2013, at 18:36, adg@golang.org wrote: > Reviewers: golang-dev1, > > Message: > Hello ...
9 years, 4 months ago (2013-07-22 08:40:01 UTC) #2
adg
9 years, 4 months ago (2013-07-22 08:41:36 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=2de1a6879076 ***

[release-branch.go1.1] time: prevent a panic from leaving the timer mutex held

««« CL 10373047 / 974a69ed9fcf
time: prevent a panic from leaving the timer mutex held

When deleting a timer, a panic due to nil deref
would leave a lock held, possibly leading to a deadlock
in a defer. Instead return false on a nil timer.

Fixes issue 5745.

R=golang-dev, daniel.morsing, dvyukov, rsc, iant
CC=golang-dev
https://codereview.appspot.com/10373047

Committer: Russ Cox <rsc@golang.org>
»»»

Update issue 5928

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/11666046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b