Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(96)

Issue 11647043: code review 11647043: runtime: Stop arm memmove corrupting its parameters (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by Nick Craig-Wood
Modified:
8 years, 9 months ago
Reviewers:
rsc, dfc
CC:
golang-dev, bradfitz, dfc, remyoudompheng, nick_craig-wood.com, rsc, dave cheney
Visibility:
Public.

Description

runtime: Stop arm memmove corrupting its parameters Change use of x+(SP) to access the stack frame into x-(SP) Fixes issue 5925.

Patch Set 1 #

Patch Set 2 : diff -r 3bf9ffdcca1f https://code.google.com/p/go #

Patch Set 3 : diff -r 3bf9ffdcca1f https://code.google.com/p/go #

Patch Set 4 : diff -r f454ddfc8968 https://code.google.com/p/go #

Patch Set 5 : diff -r f454ddfc8968 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/pkg/runtime/memmove_arm.s View 1 2 3 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 16
Nick Craig-Wood
Hello golang-dev@googlegroups.com (cc: dave cheney <dave@cheney.net>), I'd like you to review this change to https://code.google.com/p/go
9 years ago (2013-07-21 07:35:58 UTC) #1
bradfitz
How did this manifest itself? Can you write a test that failed before but passes ...
9 years ago (2013-07-22 00:40:01 UTC) #2
dfc
I don't think it is possible to do so. As I understand the issue correctly, ...
9 years ago (2013-07-22 00:43:06 UTC) #3
remyoudompheng
Le 22 juil. 2013 02:40, <bradfitz@golang.org> a écrit : > > How did this manifest ...
9 years ago (2013-07-22 05:59:45 UTC) #4
bradfitz
Sounds testable. On Jul 21, 2013 10:59 PM, "Rémy Oudompheng" <remyoudompheng@gmail.com> wrote: > > Le ...
9 years ago (2013-07-22 06:02:46 UTC) #5
nick_craig-wood.com
On 22/07/13 07:02, Brad Fitzpatrick wrote: > Sounds testable. > > On Jul 21, 2013 ...
9 years ago (2013-07-22 08:59:12 UTC) #6
rsc
I admire the desire to test everything, but this test would just be scar tissue. ...
9 years ago (2013-07-22 14:58:30 UTC) #7
nick_craig-wood.com
On 22/07/13 15:58, Russ Cox wrote: > That said, the fix is wrong. The correct ...
9 years ago (2013-07-22 15:55:39 UTC) #8
rsc
No, the name-offset(SP) syntax is consistent across all architectures. A 386 function with a frame ...
9 years ago (2013-07-22 16:06:51 UTC) #9
nick_craig-wood.com
On 22/07/13 17:06, Russ Cox wrote: > No, the name-offset(SP) syntax is consistent across all ...
9 years ago (2013-07-22 16:16:59 UTC) #10
rsc
On Mon, Jul 22, 2013 at 12:16 PM, Nick Craig-Wood <nick@craig-wood.com>wrote: > On 22/07/13 17:06, ...
9 years ago (2013-07-22 16:44:36 UTC) #11
Nick Craig-Wood
Hello golang-dev@googlegroups.com, bradfitz@golang.org, dave@cheney.net, remyoudompheng@gmail.com, nick@craig-wood.com, rsc@golang.org (cc: dave cheney <dave@cheney.net>, golang-dev@googlegroups.com), Please take another ...
9 years ago (2013-07-22 18:24:23 UTC) #12
Nick Craig-Wood
On 2013/07/22 18:24:23, Nick Craig-Wood wrote: > Hello mailto:golang-dev@googlegroups.com, mailto:bradfitz@golang.org, mailto:dave@cheney.net, > mailto:remyoudompheng@gmail.com, mailto:nick@craig-wood.com, mailto:rsc@golang.org ...
9 years ago (2013-07-22 18:25:46 UTC) #13
rsc
LGTM Thanks, and apologies.
9 years ago (2013-07-22 18:31:07 UTC) #14
dfc
LGTM. Thanks Russ and Nick. Submitting.
9 years ago (2013-07-22 23:27:29 UTC) #15
dfc
9 years ago (2013-07-22 23:29:44 UTC) #16
*** Submitted as https://code.google.com/p/go/source/detail?r=e560004b817d ***

runtime: Stop arm memmove corrupting its parameters

Change use of x+(SP) to access the stack frame into x-(SP)

Fixes issue 5925.

R=golang-dev, bradfitz, dave, remyoudompheng, nick, rsc
CC=dave cheney <dave, golang-dev
https://codereview.appspot.com/11647043

Committer: Dave Cheney <dave@cheney.net>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b