code review 116330043: cmd/5l: remove unused noop.c

cmd/5l: remove unused noop.c

[minux, 2014-07-26 07:27:43]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2014-07-26 11:08:13]

LGTM.


On Sat, Jul 26, 2014 at 5:27 PM, <minux@golang.org> wrote:

> Reviewers: rsc,
>
> Message:
> Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/5l: remove unused noop.c
>
> Please review this at https://codereview.appspot.com/116330043/
>
> Affected files (+0, -44 lines):
>   M src/cmd/5l/l.h
>   R src/cmd/5l/noop.c
>
>
> Index: src/cmd/5l/l.h
> ===================================================================
> --- a/src/cmd/5l/l.h
> +++ b/src/cmd/5l/l.h
> @@ -160,7 +160,6 @@
>  void   lput(int32 l);
>  int    machoreloc1(Reloc *r, vlong sectoff);
>  void   main(int argc, char *argv[]);
> -void   noops(void);
>  void   nopstat(char *f, Count *c);
>  int32  rnd(int32 v, int32 r);
>  void   wput(int32 l);
> Index: src/cmd/5l/noop.c
> ===================================================================
> deleted file mode 100644
> --- a/src/cmd/5l/noop.c
> +++ /dev/null
> @@ -1,43 +0,0 @@
> -// Inferno utils/5l/noop.c
> -// http://code.google.com/p/inferno-os/source/browse/utils/5l/noop.c
> -//
> -//     Copyright © 1994-1999 Lucent Technologies Inc.  All rights
> reserved.
> -//     Portions Copyright © 1995-1997 C H Forsyth (forsyth@terzarima.net)
> -//     Portions Copyright © 1997-1999 Vita Nuova Limited
> -//     Portions Copyright © 2000-2007 Vita Nuova Holdings Limited (
> www.vitanuova.com)
> -//     Portions Copyright © 2004,2006 Bruce Ellis
> -//     Portions Copyright © 2005-2007 C H Forsyth (forsyth@terzarima.net)
> -//     Revisions Copyright © 2000-2007 Lucent Technologies Inc. and others
> -//     Portions Copyright © 2009 The Go Authors.  All rights reserved.
> -//
> -// Permission is hereby granted, free of charge, to any person obtaining
> a copy
> -// of this software and associated documentation files (the "Software"),
> to deal
> -// in the Software without restriction, including without limitation the
> rights
> -// to use, copy, modify, merge, publish, distribute, sublicense, and/or
> sell
> -// copies of the Software, and to permit persons to whom the Software is
> -// furnished to do so, subject to the following conditions:
> -//
> -// The above copyright notice and this permission notice shall be
> included in
> -// all copies or substantial portions of the Software.
> -//
> -// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> -// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> -// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT
> SHALL THE
> -// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> -// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING FROM,
> -// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> IN
> -// THE SOFTWARE.
> -
> -// Code transformations.
> -
> -#include       "l.h"
> -#include       "../ld/lib.h"
> -
> -void
> -noops(void)
> -{
> -       LSym *s;
> -
> -       for(s = ctxt->textp; s != nil; s = s->next)
> -               ctxt->arch->addstacksplit(ctxt, s);
> -}
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[minux, 2014-07-26 21:44:50]

*** Submitted as https://code.google.com/p/go/source/detail?r=656ff1aa7e8a ***

cmd/5l: remove unused noop.c

LGTM=dave
R=rsc, dave
CC=golang-codereviews
https://codereview.appspot.com/116330043