Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37)

Issue 11629044: code review 11629044: [release-branch.go1.1] cmd/gc: fix missing export data ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by adg
Modified:
9 years, 4 months ago
Reviewers:
dfc
CC:
golang-dev, dfc
Visibility:
Public.

Description

[release-branch.go1.1] cmd/gc: fix missing export data for inlining in a few other cases. ««« CL 10464043 / c224c549a3c7 cmd/gc: fix missing export data for inlining in a few other cases. Exported inlined functions that perform a string conversion using a non-exported named type may miss it in export data. Fixes issue 5755. R=rsc, golang-dev, ality, r CC=golang-dev https://codereview.appspot.com/10464043 »»» Update issue 5928

Patch Set 1 #

Patch Set 2 : diff -r 31a32150a72b https://code.google.com/p/go #

Patch Set 3 : diff -r 31a32150a72b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -0 lines) Patch
M src/cmd/gc/export.c View 1 1 chunk +5 lines, -0 lines 0 comments Download
A test/fixedbugs/issue5755.go View 1 1 chunk +10 lines, -0 lines 0 comments Download
A test/fixedbugs/issue5755.dir/a.go View 1 1 chunk +60 lines, -0 lines 0 comments Download
A test/fixedbugs/issue5755.dir/main.go View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 4 months ago (2013-07-22 08:24:14 UTC) #1
dfc
LGTM. On 22/07/2013, at 18:24, adg@golang.org wrote: > Reviewers: golang-dev1, > > Message: > Hello ...
9 years, 4 months ago (2013-07-22 08:26:44 UTC) #2
adg
9 years, 4 months ago (2013-07-22 08:34:49 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=7f7bdef7fc85 ***

[release-branch.go1.1] cmd/gc: fix missing export data for inlining in a few
other cases.

««« CL 10464043 / c224c549a3c7
cmd/gc: fix missing export data for inlining in a few other cases.

Exported inlined functions that perform a string conversion
using a non-exported named type may miss it in export data.

Fixes issue 5755.

R=rsc, golang-dev, ality, r
CC=golang-dev
https://codereview.appspot.com/10464043
»»»

Update issue 5928

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/11629044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b