Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(623)

Issue 11620046: code review 11620046: database/sql: close statement before connection (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by brainman
Modified:
7 years, 6 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

database/sql: close statement before connection Fixes issue 5936

Patch Set 1 #

Patch Set 2 : diff -r 677f1dc462af https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 677f1dc462af https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 977306015f5d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/pkg/database/sql/sql.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/database/sql/sql_test.go View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 6 months ago (2013-07-23 01:28:50 UTC) #1
brainman
Added "Fixes issue 5936". Alex
7 years, 6 months ago (2013-07-23 03:20:38 UTC) #2
bradfitz
LGTM Thanks! On Mon, Jul 22, 2013 at 6:28 PM, <alex.brainman@gmail.com> wrote: > Reviewers: golang-dev1, ...
7 years, 6 months ago (2013-07-23 03:49:39 UTC) #3
brainman
7 years, 6 months ago (2013-07-23 04:10:02 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=a86c5dc7e7e9 ***

database/sql: close statement before connection

Fixes issue 5936

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/11620046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b