Issue 11615044: code review 11615044: cmd/ld: fix warnings on Plan 9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11615044: code review 11615044: cmd/ld: fix warnings on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by 0intro

Modified:
11 years, 6 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/ld: fix warnings on Plan 9 src/cmd/ld/lib.c:1379 set and not used: p src/cmd/ld/lib.c:1426 format mismatch 6llux INT, arg 3 src/cmd/ld/lib.c:1437 format mismatch 6llux INT, arg 3 src/cmd/ld/lib.c:1456 format mismatch 6llux INT, arg 3 src/cmd/ld/lib.c:1477 format mismatch 6llux INT, arg 3 src/cmd/ld/lib.c:1459 set and not used: started

Patch Set 1 #

Patch Set 2 : diff -r 3d177aef8dd3 https://code.google.com/p/go #

Patch Set 3 : diff -r 3d177aef8dd3 https://code.google.com/p/go #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	src/cmd/ld/lib.c	View	1	5 chunks	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

0intro

Hello golang-dev1 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 8 months ago (2013-07-22 20:51:33 UTC) #1

rsc

11 years, 8 months ago (2013-07-22 21:33:44 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=6782fb307e4e ***

cmd/ld: fix warnings on Plan 9

src/cmd/ld/lib.c:1379 set and not used: p
src/cmd/ld/lib.c:1426 format mismatch 6llux INT, arg 3
src/cmd/ld/lib.c:1437 format mismatch 6llux INT, arg 3
src/cmd/ld/lib.c:1456 format mismatch 6llux INT, arg 3
src/cmd/ld/lib.c:1477 format mismatch 6llux INT, arg 3
src/cmd/ld/lib.c:1459 set and not used: started

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/11615044

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages