Issue 11611043: Aligns Charm id and BrowserCharm id

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11611043: Aligns Charm id and BrowserCharm id

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by j.c.sackett

Modified:
10 years, 9 months ago

Reviewers:
benjamin.saller, mp+175953, jeff.pihach

Visibility:
Public.

Description

Aligns Charm id and BrowserCharm id This branch represents the second painful step in aligning the charm models and running everything off the up to date charmworld API. -Charm and BrowserCharm both now have an attr named StoreId; this is the id for use with the data store (e.g. precise/ceph-12). id is now aligned with the fully qualified id (e.g. cs:precise/ceph-12) on both models. -A number of data shims in initializers are introduced to ensure that these properties are set properly in both models. https://code.launchpad.net/~jcsackett/juju-gui/charmbrowser-id-woes/+merge/175953 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Aligns Charm id and BrowserCharm id #

Patch Set 3 : Aligns Charm id and BrowserCharm id #

Patch Set 4 : Aligns Charm id and BrowserCharm id #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -30 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/charm.js	View		4 chunks	+18 lines, -4 lines	0 comments	Download
M	app/subapps/browser/templates/browser_charm.handlebars	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/subapps/browser/views/charm.js	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	app/templates/charm-token.handlebars	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	app/views/viewlets/charm-details.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/views/viewlets/unit-details.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	app/widgets/charm-token.js	View	1	3 chunks	+12 lines, -12 lines	0 comments	Download
M	test/test_inspector_charm.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_model.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM thanks I did the QA, things seemed to work, didn't find fallout, but it ...

10 years, 9 months ago (2013-07-19 21:49:55 UTC) #2

jeff.pihach

LGTM qa'd https://codereview.appspot.com/11611043/diff/1/app/widgets/charm-token.js File app/widgets/charm-token.js (right): https://codereview.appspot.com/11611043/diff/1/app/widgets/charm-token.js#newcode48 app/widgets/charm-token.js:48: // Extract the charm cfguration values from ...

10 years, 9 months ago (2013-07-19 21:52:04 UTC) #3

j.c.sackett

10 years, 9 months ago (2013-07-22 14:03:12 UTC) #4

*** Submitted:

Aligns Charm id and BrowserCharm id

This branch represents the second painful step in aligning the charm models and
running everything off the up to date charmworld API.
-Charm and BrowserCharm both now have an attr named StoreId; this is the id for
use with the data store (e.g. precise/ceph-12). id is now aligned with the fully
qualified id (e.g. cs:precise/ceph-12) on both models.
-A number of data shims in initializers are introduced to ensure that these
properties are set properly in both models.

R=benjamin.saller, jeff.pihach
CC=
https://codereview.appspot.com/11611043

Expand All Messages | Collapse All Messages