Issue 11607043: Refactor and style ghost and inspector headers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11607043: Refactor and style ghost and inspector headers

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jeff.pihach

Modified:
10 years, 9 months ago

Reviewers:
mp+175941, matthew.scott, benjamin.saller

Visibility:
Public.

Description

Refactor and style ghost and inspector headers https://code.launchpad.net/~hatch/juju-gui/inspector-header-refactor/+merge/175941 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Refactor and style ghost and inspector headers #

Patch Set 3 : Refactor and style ghost and inspector headers #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -94 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/modules-debug.js	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	app/templates/ghost-config-wrapper.handlebars	View	1 2	3 chunks	+2 lines, -19 lines	0 comments	Download
A	app/templates/inspector-header.handlebars	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	app/templates/serviceOverview.handlebars	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	app/templates/view-container.handlebars	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/views/environment.js	View	1 2	3 chunks	+5 lines, -3 lines	0 comments	Download
M	app/views/inspector.js	View	1	3 chunks	+5 lines, -18 lines	0 comments	Download
M	app/views/view-container.js	View	1 2	3 chunks	+4 lines, -2 lines	0 comments	Download
A	app/views/viewlets/inspector-header.js	View		1 chunk	+71 lines, -0 lines	0 comments	Download
M	lib/views/juju-inspector.less	View		11 chunks	+65 lines, -45 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

benjamin.saller

As talked, need trunk merge Also the charm details isn't even bound to show the ...

10 years, 9 months ago (2013-07-19 20:49:55 UTC) #2

jeff.pihach

10 years, 9 months ago (2013-07-19 21:14:27 UTC) #6

*** Submitted:

Refactor and style ghost and inspector headers

R=benjamin.saller, matthew.scott
CC=
https://codereview.appspot.com/11607043

Expand All Messages | Collapse All Messages