code review 116050043: test: avoid "declared but not used" errors in shift1.go

test: avoid "declared but not used" errors in shift1.go

I'm improving gccgo's detection of variables that are only set
but not used, and it triggers additional errors on this code.
The new gccgo errors are correct; gc seems to suppress them
due to the other, expected, errors.  This change uses the
variables so that no compiler will complain.

gccgo change is http://codereview.appspot.com/119920043 .

[iant, 2014-07-20 19:17:19]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-07-20 19:18:47]

LGTM



On Sun, Jul 20, 2014 at 12:17 PM, <iant@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> test: avoid "declared but not used" errors in shift1.go
>
> I'm improving gccgo's detection of variables that are only set
> but not used, and it triggers additional errors on this code.
> The new gccgo errors are correct; gc seems to suppress them
> due to the other, expected, errors.  This change uses the
> variables so that no compiler will complain.
>
> gccgo change is http://codereview.appspot.com/119920043 .
>
> Please review this at https://codereview.appspot.com/116050043/
>
> Affected files (+2, -0 lines):
>   M test/shift1.go
>
>
> Index: test/shift1.go
> ===================================================================
> --- a/test/shift1.go
> +++ b/test/shift1.go
> @@ -238,4 +238,6 @@
>         z = (1. << s) << (1 << s)    // ERROR "non-integer|type complex128"
>         z = (1. << s) << (1. << s)   // ERROR "non-integer|type complex128"
>         z = (1.1 << s) << (1.1 << s) // ERROR
> "invalid|truncated|complex128"
> +
> +       _, _, _ = x, y, z
>  }
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[iant, 2014-07-20 19:25:27]

*** Submitted as https://code.google.com/p/go/source/detail?r=bbddc25284e9 ***

test: avoid "declared but not used" errors in shift1.go

I'm improving gccgo's detection of variables that are only set
but not used, and it triggers additional errors on this code.
The new gccgo errors are correct; gc seems to suppress them
due to the other, expected, errors.  This change uses the
variables so that no compiler will complain.

gccgo change is http://codereview.appspot.com/119920043 .

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/116050043