Issue 11598043: Remove the seperate browser store vs app store.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11598043: Remove the seperate browser store vs app store.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by rharding

Modified:
10 years, 9 months ago

Reviewers:
benjamin.saller, matthew.scott, mp+175925

Visibility:
Public.

Description

Remove the seperate browser store vs app store. - The App.js contains the one true store and passes it down to subapps. - The subapp then needs to be handed a store in a couple of tests to work correctly. https://code.launchpad.net/~rharding/juju-gui/share-store/+merge/175925 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove the seperate browser store vs app store. #

Patch Set 3 : Remove the seperate browser store vs app store. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -28 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	app/subapps/browser/browser.js	View		1 chunk	+1 line, -23 lines	0 comments	Download
M	test/test_browser_app.js	View		4 chunks	+20 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rharding

10 years, 9 months ago (2013-07-22 12:54:48 UTC) #5

*** Submitted:

Remove the seperate browser store vs app store.

- The App.js contains the one true store and passes it down to subapps.
- The subapp then needs to be handed a store in a couple of tests to work
correctly.

R=matthew.scott, benjamin.saller
CC=
https://codereview.appspot.com/11598043

Expand All Messages | Collapse All Messages