code review 115960043: encoding/gob: make benchmarks parallel

encoding/gob: make benchmarks parallel
There are lots of internal synchronization in gob,
so it makes sense to have parallel benchmarks.
Also add a benchmark with slices and interfaces.

[dvyukov, 2014-07-18 10:29:32]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[dvyukov, 2014-07-18 10:30:08]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[r, 2014-07-18 20:31:19]

not sure this is worth it since the stream is serialized.

https://codereview.appspot.com/115960043/diff/50001/src/pkg/encoding/gob/timi...
File src/pkg/encoding/gob/timing_test.go (right):

https://codereview.appspot.com/115960043/diff/50001/src/pkg/encoding/gob/timi...
src/pkg/encoding/gob/timing_test.go:57: func BenchmarkEndToEndArrayByteBuffer(b
*testing.B) {
s/Array/Slice/ here and in CL description

[dvyukov, 2014-07-19 07:10:50]

On Sat, Jul 19, 2014 at 12:31 AM,  <r@golang.org> wrote:
> not sure this is worth it since the stream is serialized.

It is serialized only per-connection, not globally.


https://codereview.appspot.com/115960043/diff/50001/src/pkg/encoding/gob/timi...
> File src/pkg/encoding/gob/timing_test.go (right):
>
>
https://codereview.appspot.com/115960043/diff/50001/src/pkg/encoding/gob/timi...
> src/pkg/encoding/gob/timing_test.go:57: func
> BenchmarkEndToEndArrayByteBuffer(b *testing.B) {
> s/Array/Slice/ here and in CL description
>
> https://codereview.appspot.com/115960043/

[dvyukov, 2014-08-07 15:27:48]

On 2014/07/19 07:10:50, dvyukov wrote:
> On Sat, Jul 19, 2014 at 12:31 AM,  <mailto:r@golang.org> wrote:
> > not sure this is worth it since the stream is serialized.
> 
> It is serialized only per-connection, not globally.
> 
> 
>
https://codereview.appspot.com/115960043/diff/50001/src/pkg/encoding/gob/timi...
> > File src/pkg/encoding/gob/timing_test.go (right):
> >
> >
>
https://codereview.appspot.com/115960043/diff/50001/src/pkg/encoding/gob/timi...
> > src/pkg/encoding/gob/timing_test.go:57: func
> > BenchmarkEndToEndArrayByteBuffer(b *testing.B) {
> > s/Array/Slice/ here and in CL description
> >
> > https://codereview.appspot.com/115960043/


Rob, you've just submitted a scalability improvement to gob. Can you reconsider
this change?

[r, 2014-08-07 15:41:30]

address my comment and i'll sign off

[dvyukov, 2014-08-07 15:56:51]

On 2014/08/07 15:41:30, r wrote:
> address my comment and i'll sign off

Done
PTAL

[r, 2014-08-07 17:14:04]

LGTM

[dvyukov, 2014-08-07 17:39:38]

*** Submitted as https://code.google.com/p/go/source/detail?r=a8843f90d292 ***

encoding/gob: make benchmarks parallel
There are lots of internal synchronization in gob,
so it makes sense to have parallel benchmarks.
Also add a benchmark with slices and interfaces.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/115960043

[gobot, 2014-08-07 17:57:10]

This CL appears to have broken the linux-amd64-race builder.
See http://build.golang.org/log/e70a89469ce619827e85db35f2407fca2b061865

[dvyukov, 2014-08-07 18:18:15]

on it

On Thu, Aug 7, 2014 at 9:57 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the linux-amd64-race builder.
> See http://build.golang.org/log/e70a89469ce619827e85db35f2407fca2b061865
>
> https://codereview.appspot.com/115960043/