Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3636)

Issue 11593043: Tweak CSS for OSCON

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by gary.poster
Modified:
10 years, 9 months ago
Reviewers:
jeff.pihach, benji, mp+175910
Visibility:
Public.

Description

Tweak CSS for OSCON This branch has three visual fixes. Two of them are supposed to last, and the other is throw-away. - GOOD: commits were not pluralizing correctly. This is because they were strings, not ints. I changed the code to send ints. - GOOD: on the charm token, the download and commit line was not floating propoerly for some charms because the line was getting too long. I tweaked the CSS to force a width, with ellipses. - THROW-AWAY: in the old, old charm page, the page was no longer scrollable. I added code to set the height as we have done on other pages. This should actually destroy subscriptions and do other nice clean up things, but this page will be destroyed as soon as we get the inspector. https://code.launchpad.net/~gary/juju-gui/cssfixes/+merge/175910 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Tweak CSS for OSCON #

Patch Set 3 : Tweak CSS for OSCON #

Patch Set 4 : Tweak CSS for OSCON #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -78 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/charm.js View 2 chunks +2 lines, -2 lines 0 comments Download
M app/templates/charm.handlebars View 1 chunk +78 lines, -76 lines 0 comments Download
M app/views/charm.js View 2 chunks +31 lines, -0 lines 0 comments Download
M lib/views/browser/charm-token.less View 1 chunk +6 lines, -0 lines 0 comments Download
M lib/views/stylesheet.less View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5
gary.poster
Please take a look.
10 years, 9 months ago (2013-07-19 17:53:17 UTC) #1
jeff.pihach
LGTM Thanks for the fix
10 years, 9 months ago (2013-07-19 17:59:57 UTC) #2
benji
Other than one paranoid comment this looks good. LGTM-ly y'rs, Benji https://codereview.appspot.com/11593043/diff/1/app/views/charm.js File app/views/charm.js (right): ...
10 years, 9 months ago (2013-07-19 18:02:02 UTC) #3
gary.poster
Please take a look.
10 years, 9 months ago (2013-07-19 18:18:59 UTC) #4
gary.poster
10 years, 9 months ago (2013-07-19 18:26:59 UTC) #5
*** Submitted:

Tweak CSS for OSCON

This branch has three visual fixes.  Two of them are supposed to last, and the
other is throw-away.

- GOOD: commits were not pluralizing correctly.  This is because they were
strings, not ints.  I changed the code to send ints.
- GOOD: on the charm token, the download and commit line was not floating
propoerly for some charms because the line was getting too long.  I tweaked the
CSS to force a width, with ellipses.
- THROW-AWAY: in the old, old charm page, the page was no longer scrollable.  I
added code to set the height as we have done on other pages.  This should
actually destroy subscriptions and do other nice clean up things, but this page
will be destroyed as soon as we get the inspector.

R=jeff.pihach, benji
CC=
https://codereview.appspot.com/11593043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b