Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16570)

Issue 11589043: version: marshal to JSON string

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by rog
Modified:
10 years, 9 months ago
Reviewers:
mue, fwereade, mp+175895
Visibility:
Public.

Description

version: marshal to JSON string This will make the API look nicer. https://code.launchpad.net/~rogpeppe/juju-core/342-version-json-marshal/+merge/175895 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : version: marshal to JSON string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -22 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M version/version.go View 3 chunks +35 lines, -0 lines 0 comments Download
M version/version_test.go View 1 2 chunks +42 lines, -22 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
10 years, 9 months ago (2013-07-19 17:00:38 UTC) #1
mue
LGTM
10 years, 9 months ago (2013-07-19 17:04:16 UTC) #2
fwereade
10 years, 9 months ago (2013-07-19 17:04:27 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b