Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(69)

Issue 115860045: code review 115860045: runtime: add throwgo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by dave
Modified:
10 years, 7 months ago
Reviewers:
khr, khr1, elias.naur
CC:
khr, rsc, khr1, golang-codereviews
Visibility:
Public.

Description

runtime: add throwgo Fixes issue 8380. Also update hashmap.go to use throwgo rather than panic.

Patch Set 1 #

Patch Set 2 : diff -r 8e05add24c7e https://code.google.com/p/go #

Patch Set 3 : diff -r 8e05add24c7e https://code.google.com/p/go #

Patch Set 4 : diff -r 8e05add24c7e https://code.google.com/p/go #

Patch Set 5 : diff -r 8e05add24c7e https://code.google.com/p/go #

Patch Set 6 : diff -r 8e05add24c7e https://code.google.com/p/go #

Patch Set 7 : diff -r 8e05add24c7e https://code.google.com/p/go #

Patch Set 8 : diff -r bac0a67b0b70 https://code.google.com/p/go #

Patch Set 9 : diff -r bac0a67b0b70 https://code.google.com/p/go #

Patch Set 10 : diff -r bac0a67b0b70 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -15 lines) Patch
M src/pkg/runtime/hashmap.go View 1 2 3 6 chunks +13 lines, -15 lines 0 comments Download
M src/pkg/runtime/panic.c View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/pkg/runtime/stubs.go View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7
dave_cheney.net
Hello khr@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 8 months ago (2014-07-18 00:35:34 UTC) #1
khr
On 2014/07/18 00:35:34, dfc wrote: > Hello mailto:khr@golang.org, mailto:rsc@golang.org (cc: mailto:golang-codereviews@googlegroups.com), > > I'd like ...
10 years, 8 months ago (2014-07-18 01:07:13 UTC) #2
dave_cheney.net
> You could put the throwgo declaration in stubs.go. That was the file I was ...
10 years, 8 months ago (2014-07-18 01:20:26 UTC) #3
khr1
LGTM. On Thu, Jul 17, 2014 at 6:20 PM, <dave@cheney.net> wrote: > You could put ...
10 years, 8 months ago (2014-07-18 06:26:22 UTC) #4
dave_cheney.net
*** Submitted as https://code.google.com/p/go/source/detail?r=2facb9da08d5 *** runtime: add throwgo Fixes issue 8380. Also update hashmap.go to ...
10 years, 8 months ago (2014-07-18 06:30:56 UTC) #5
elias.naur
On 2014/07/18 06:30:56, dfc wrote: > *** Submitted as https://code.google.com/p/go/source/detail?r=2facb9da08d5 *** > > runtime: add ...
10 years, 8 months ago (2014-07-18 11:31:10 UTC) #6
dave_cheney.net
10 years, 7 months ago (2014-07-22 00:14:45 UTC) #7
I agree, this was a mistake on my part. I will prepare a change to correct
this tonight.


On Fri, Jul 18, 2014 at 9:31 PM, <elias.naur@gmail.com> wrote:

> On 2014/07/18 06:30:56, dfc wrote:
>
>> *** Submitted as
>>
> https://code.google.com/p/go/source/detail?r=2facb9da08d5 ***
>
>  runtime: add throwgo
>>
>
>  Fixes issue 8380.
>>
>
>  Also update hashmap.go to use throwgo rather than panic.
>>
>
>  LGTM=khr
>> R=khr, rsc
>> CC=golang-codereviews
>> https://codereview.appspot.com/115860045
>>
>
> I'm a bit late to the party, but I'd like to mention that the other
> functions in stubs.go (gogetcallerpc, goeq, gohash, gocas, gomemeq) use
> "go" as prefix, not suffix. ,
>
> https://codereview.appspot.com/115860045/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b