Issue 115860043: code review 115860043: encoding/gob: remove unnecessary receivers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 115860043: code review 115860043: encoding/gob: remove unnecessary receivers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by dvyukov

Modified:
10 years, 10 months ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

encoding/gob: remove unnecessary receivers Encoder compilation must be enc-independent, because the resulting program is reused across different encoders.

Patch Set 1 #

Patch Set 2 : diff -r 9562b65a3c51 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 9562b65a3c51 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 99630144d7fc https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -18 lines)			Patch
	M	src/pkg/encoding/gob/encode.go	View	1	11 chunks	+17 lines, -18 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

10 years, 10 months ago (2014-07-16 16:28:05 UTC) #1

dvyukov

10 years, 10 months ago (2014-07-18 08:39:06 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=2d172468516f ***

encoding/gob: remove unnecessary receivers
Encoder compilation must be enc-independent,
because the resulting program is reused across
different encoders.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/115860043

Expand All Messages | Collapse All Messages