Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74)

Issue 115820043: code review 115820043: cmd/ld: generate correct upper bound value for array types. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by r
Modified:
10 years, 8 months ago
Reviewers:
rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

cmd/ld: generate correct upper bound value for array types.

Patch Set 1 #

Patch Set 2 : diff -r 6866fbf95095 https://code.google.com/p/go #

Patch Set 3 : diff -r 9bf5f4dd2857 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/cmd/ld/decodesym.c View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/cmd/ld/dwarf.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
r
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 8 months ago (2014-07-14 22:53:02 UTC) #1
rsc
I know this is what I suggested but the decode routines are not necessarily dwarf-specific, ...
10 years, 8 months ago (2014-07-14 23:11:32 UTC) #2
r
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 8 months ago (2014-07-14 23:31:01 UTC) #3
rsc
LGTM
10 years, 8 months ago (2014-07-15 00:46:46 UTC) #4
r
10 years, 8 months ago (2014-07-15 01:38:08 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=59db6f912bf3 ***

cmd/ld: generate correct upper bound value for array types.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/115820043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b