Issue 11579043: Move inspector code to own module. No func change

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11579043: Move inspector code to own module. No func change

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by rharding

Modified:
10 years, 9 months ago

Reviewers:
mp+175849, jeff.pihach, gary.poster

Visibility:
Public.

Description

Move inspector code to own module. No func change - Move the inspector view related code to a new views/inspector.js - A couple of objects are used in both service.js and inspector.js so they're attached to the namespace and shared. - Updated tests to pull in required modules to pass. - A few small nit-picks, ordering of imports, var names, etc. https://code.launchpad.net/~rharding/juju-gui/reorg-inspector-module/+merge/175849 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Move inspector code to own module. No func change #

Patch Set 3 : Move inspector code to own module. No func change #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1580 lines, -1486 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/assets/javascripts/Object.observe.poly.js	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	app/modules-debug.js	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	app/views/databinding.js	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
M	app/views/environment.js	View	1 2	1 chunk	+11 lines, -8 lines	0 comments	Download
A	app/views/inspector.js	View	1 2	1 chunk	+1349 lines, -0 lines	0 comments	Download
M	app/views/service.js	View	1 2	4 chunks	+17 lines, -1297 lines	0 comments	Download
M	test/test_service_config_view.js	View		1 chunk	+15 lines, -6 lines	0 comments	Download
M	undocumented	View		2 chunks	+175 lines, -174 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rharding

10 years, 9 months ago (2013-07-19 18:14:04 UTC) #4

*** Submitted:

Move inspector code to own module. No func change

- Move the inspector view related code to a new views/inspector.js
- A couple of objects are used in both service.js and inspector.js so they're
attached to the namespace and shared.
- Updated tests to pull in required modules to pass.
- A few small nit-picks, ordering of imports, var names, etc.

R=gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/11579043

Expand All Messages | Collapse All Messages