Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1270)

Issue 115780043: code review 115780043: runtime: improve select benchmarks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by dvyukov
Modified:
10 years, 8 months ago
Reviewers:
gobot, khr1
CC:
golang-codereviews, khr, khr1
Visibility:
Public.

Description

runtime: improve select benchmarks 1. Add select on sync channels benchmark. 2. Make channels in BenchmarkSelectNonblock shared. With GOMAXPROCS=1 it is the same, but with GOMAXPROCS>1 it becomes a more interesting benchmark.

Patch Set 1 #

Patch Set 2 : diff -r 67f9ef140028 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 67f9ef140028 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r b850cb862bb2 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M src/pkg/runtime/chan_test.go View 1 2 chunks +33 lines, -5 lines 0 comments Download

Messages

Total messages: 6
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 8 months ago (2014-07-14 11:22:11 UTC) #1
khr
https://codereview.appspot.com/115780043/diff/40001/src/pkg/runtime/chan_test.go File src/pkg/runtime/chan_test.go (right): https://codereview.appspot.com/115780043/diff/40001/src/pkg/runtime/chan_test.go#newcode510 src/pkg/runtime/chan_test.go:510: myc4 := make(chan int, 1) Now all the selects ...
10 years, 8 months ago (2014-07-17 04:27:11 UTC) #2
dvyukov
https://codereview.appspot.com/115780043/diff/40001/src/pkg/runtime/chan_test.go File src/pkg/runtime/chan_test.go (right): https://codereview.appspot.com/115780043/diff/40001/src/pkg/runtime/chan_test.go#newcode510 src/pkg/runtime/chan_test.go:510: myc4 := make(chan int, 1) On 2014/07/17 04:27:11, khr ...
10 years, 8 months ago (2014-07-17 04:32:39 UTC) #3
khr1
LGTM. On Wed, Jul 16, 2014 at 9:32 PM, <dvyukov@google.com> wrote: > > https://codereview.appspot.com/115780043/diff/40001/src/ > ...
10 years, 8 months ago (2014-07-17 04:33:47 UTC) #4
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=f2fb9e3b91d1 *** runtime: improve select benchmarks 1. Add select on sync channels ...
10 years, 8 months ago (2014-07-17 17:49:52 UTC) #5
gobot
10 years, 8 months ago (2014-07-17 18:04:40 UTC) #6
Message was sent while issue was closed.
This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/67a1fe57a951fb48630f573163823192639899ba
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b