Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(532)

Issue 11577044: Move config.js into the HEAD of the body.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by rharding
Modified:
10 years, 9 months ago
Reviewers:
mp+176463, gary.poster
Visibility:
Public.

Description

Move config.js into the HEAD of the body. - Defer didn't help. Error still occurred. - It's clear that the config.js either hadn't finished downloading or parsing. - It can be run stand alone so moved to the head to get it up the request list grouping. https://code.launchpad.net/~rharding/juju-gui/undefer/+merge/176463 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Move config.js into the HEAD of the body. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/index.html View 3 chunks +7 lines, -16 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
10 years, 9 months ago (2013-07-23 18:56:02 UTC) #1
rharding
LGTM self-reviewing trivial after quick discussion with gary in irc.
10 years, 9 months ago (2013-07-23 18:59:14 UTC) #2
gary.poster
LGTM. Agree that this is probably the right way forward, at least for now. We ...
10 years, 9 months ago (2013-07-23 18:59:52 UTC) #3
rharding
10 years, 9 months ago (2013-07-23 19:03:58 UTC) #4
*** Submitted:

Move config.js into the HEAD of the body.

- Defer didn't help. Error still occurred.
- It's clear that the config.js either hadn't finished downloading or parsing. 
- It can be run stand alone so moved to the head to get it up the request list
grouping.

R=
CC=
https://codereview.appspot.com/11577044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b