state/api: Implement Machiner.Watch

state/api: Implement Machiner.Watch

This is the last needed API call needed by the
machiner worker.

In a follow-up some cleaning up of the machiner
facade and tests will be performed.

https://code.launchpad.net/~dimitern/juju-core/074-api-machiner-watch/+merge/175850

Requires: https://code.launchpad.net/~dimitern/juju-core/073-apiserver-pinger-on-ma-connection/+merge/175833

(do not edit description out of merge proposal)

[dimitern, 2013-07-19 14:32:49]

Please take a look.

[rog, 2013-07-19 14:45:46]

LGTM except for the State->Machiner rename.

https://codereview.appspot.com/11574044/diff/1/state/api/machiner/machiner.go
File state/api/machiner/machiner.go (right):

https://codereview.appspot.com/11574044/diff/1/state/api/machiner/machiner.go...
state/api/machiner/machiner.go:14: type Machiner struct {
i think State is a perfectly reasonably name for this. It means we don't have to
rename all variables everywhere, and it really *is* the machiner worker's view
of the state (it's really a facade of the state, not a facade of the machiner)

i think having a Machiner talk to a Machiner is a bit odd.

[dimitern, 2013-07-19 16:01:55]

Please take a look.

https://codereview.appspot.com/11574044/diff/1/state/api/machiner/machiner.go
File state/api/machiner/machiner.go (right):

https://codereview.appspot.com/11574044/diff/1/state/api/machiner/machiner.go...
state/api/machiner/machiner.go:14: type Machiner struct {
On 2013/07/19 14:45:46, rog wrote:
> i think State is a perfectly reasonably name for this. It means we don't have
to
> rename all variables everywhere, and it really *is* the machiner worker's view
> of the state (it's really a facade of the state, not a facade of the machiner)
> 
> i think having a Machiner talk to a Machiner is a bit odd.

Done.

[fwereade, 2013-07-19 17:10:11]

LGTM

https://codereview.appspot.com/11574044/diff/5001/state/api/machiner/machiner...
File state/api/machiner/machiner_test.go (right):

https://codereview.appspot.com/11574044/diff/5001/state/api/machiner/machiner...
state/api/machiner/machiner_test.go:142: // Make the machine dying and check
it's detected.
s/dying/dead/

[dimitern, 2013-07-19 18:07:34]

Please take a look.

https://codereview.appspot.com/11574044/diff/5001/state/api/machiner/machiner...
File state/api/machiner/machiner_test.go (right):

https://codereview.appspot.com/11574044/diff/5001/state/api/machiner/machiner...
state/api/machiner/machiner_test.go:142: // Make the machine dying and check
it's detected.
On 2013/07/19 17:10:11, fwereade wrote:
> s/dying/dead/

Done.