Issue 11574043: Unit details wrapper refactoring

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11574043: Unit details wrapper refactoring

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jeff.pihach

Modified:
10 years, 9 months ago

Reviewers:
bac, matthew.scott, mp+175838

Visibility:
Public.

Description

Unit details wrapper refactoring Fixed a couple view container and databinding bugs. Wrote tests to avoid any further regressions. https://code.launchpad.net/~hatch/juju-gui/unit-left-inspector/+merge/175838 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Unit details wrapper refactoring #

Total comments: 1

Patch Set 3 : Unit details wrapper refactoring #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -71 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/modules-debug.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	app/templates/ghost-config-wrapper.handlebars	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/templates/view-container.handlebars	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/views/databinding.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	app/views/environment.js	View	1	1 chunk	+13 lines, -10 lines	0 comments	Download
M	app/views/service.js	View		3 chunks	+4 lines, -54 lines	0 comments	Download
M	app/views/view-container.js	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
A	app/views/viewlets/unit-details.js	View		1 chunk	+79 lines, -0 lines	0 comments	Download
M	test/test_databinding.js	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download
M	test/test_view_container.js	View		4 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

matthew.scott

LGTM https://codereview.appspot.com/11574043/diff/1/app/views/view-container.js File app/views/view-container.js (right): https://codereview.appspot.com/11574043/diff/1/app/views/view-container.js#newcode348 app/views/view-container.js:348: if (!viewlet) { Is this now redundant with ...

10 years, 9 months ago (2013-07-19 14:17:01 UTC) #4

jeff.pihach

10 years, 9 months ago (2013-07-19 14:28:08 UTC) #5

*** Submitted:

Unit details wrapper refactoring

Fixed a couple view container and databinding bugs.
Wrote tests to avoid any further regressions.

R=bac, matthew.scott
CC=
https://codereview.appspot.com/11574043

Expand All Messages | Collapse All Messages