Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4764)

Issue 11571044: Force the order of execution of JS using defer.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by rharding
Modified:
10 years, 9 months ago
Reviewers:
mp+176442, jeff.pihach, gary.poster
Visibility:
Public.

Description

Force the order of execution of JS using defer. - Defer allows the scripts to be downloaded async, however it *forces* the browser to execute them in the order they appear in the DOM. - There's a chance that we've had users hitting out of order execution between this code causing Y.juju.App to not be defined during startTheApp. This should force this to not occur. - Testing this just isn't possible. We're not 100% sure that it's the issue and it's darn unrepeatable. The only repeatable case was a stale cache. However, it has been demonstrated on machines in incognito mode so there is something there. It's just very hard to reproduce. https://code.launchpad.net/~rharding/juju-gui/defer-all-the-things/+merge/176442 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Force the order of execution of JS using defer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/index.html View 1 2 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
10 years, 9 months ago (2013-07-23 17:32:52 UTC) #1
gary.poster
LGTM with discussion from IRC. Namely, if we do this, please include a comment about ...
10 years, 9 months ago (2013-07-23 17:42:57 UTC) #2
jeff.pihach
LGTM with Gary's comments
10 years, 9 months ago (2013-07-23 17:56:57 UTC) #3
rharding
10 years, 9 months ago (2013-07-23 17:59:02 UTC) #4
*** Submitted:

Force the order of execution of JS using defer.

- Defer allows the scripts to be downloaded async, however it *forces* the
browser to execute them in the order they appear in the DOM.
- There's a chance that we've had users hitting out of order execution between
this code causing Y.juju.App to not be defined during startTheApp. This should
force this to not occur.

- Testing this just isn't possible. We're not 100% sure that it's the issue
and it's darn unrepeatable. The only repeatable case was a stale cache.
However, it has been demonstrated on machines in incognito mode so there is
something there. It's just very hard to reproduce.

R=gary.poster
CC=
https://codereview.appspot.com/11571044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b