Issue 115700043: Now shortened fqname is shown in trail and also used fqname instead of item_name in location_breadc…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 115700043: Now shortened fqname is shown in trail and also used fqname instead of item_name in location_breadc… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by sksaurabhkathpalia

Modified:
9 years, 8 months ago

Reviewers:
thomas.j.waldmann

Visibility:
Public.

More Reviews

Description

Now shortened fqname is shown in trail and also used fqname instead of item_name in location_breadc…

Patch Set 1 #

Total comments: 2

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	MoinMoin/themes/foobar/templates/layout.html	View		3 chunks	+7 lines, -7 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Thomas.J.Waldmann

https://codereview.appspot.com/115700043/diff/1/MoinMoin/themes/foobar/templates/layout.html File MoinMoin/themes/foobar/templates/layout.html (right): https://codereview.appspot.com/115700043/diff/1/MoinMoin/themes/foobar/templates/layout.html#newcode121 MoinMoin/themes/foobar/templates/layout.html:121: {% for segment_name, segment_path, exists in theme_supp.location_breadcrumbs(fqname) -%} location ...

9 years, 8 months ago (2014-08-06 14:35:00 UTC) #1

sksaurabhkathpalia

9 years, 8 months ago (2014-08-07 15:43:23 UTC) #2

https://codereview.appspot.com/115700043/diff/1/MoinMoin/themes/foobar/templa...
File MoinMoin/themes/foobar/templates/layout.html (right):

https://codereview.appspot.com/115700043/diff/1/MoinMoin/themes/foobar/templa...
MoinMoin/themes/foobar/templates/layout.html:121: {% for segment_name,
segment_path, exists in theme_supp.location_breadcrumbs(fqname) -%}
On 2014/08/06 14:35:00, Thomas.J.Waldmann wrote:
> location breadcrumbs deal with hierarchical NAMES like 
> main/sub/subsub.
> 
> how does this play well with fqnames in general?

If the item has no name then it shows @itemid/51b2f1bdd36f4bbaad2cc8b55db1ea21
so Now this will show shorted fqname instead of this.
This cr is specifically for nameless items.
For items having name this cr doesn't cause any affect, they are displayed as
they were previously

Expand All Messages | Collapse All Messages