code review 11568043: regexp: exclude exhaustive RE2 test from running under ...

regexp: exclude exhaustive RE2 test from running under race detector.

It is an expensive test to run, and even more so with -race,
and causes timeouts on builders. It is doubtful that it would
find a race that other tests in this package wouldn't, so there
is little loss in excluding it.

Update issue 5837.

[dsymonds, 2013-07-19 09:26:11]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-07-19 09:28:35]

Rémy also has a fix pending for this issue. 



On 19/07/2013, at 19:26, dsymonds@golang.org wrote:

> Reviewers: golang-dev1,
> 
> Message:
> Hello golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go
> 
> 
> Description:
> regexp: exclude exhaustive RE2 test from running under race detector.
> 
> It is an expensive test to run, and even more so with -race,
> and causes timeouts on builders. It is doubtful that it would
> find a race that other tests in this package wouldn't, so there
> is little loss in excluding it.
> 
> Please review this at https://codereview.appspot.com/11568043/
> 
> Affected files:
>  A src/pkg/regexp/exec2_test.go
>  M src/pkg/regexp/exec_test.go
> 
> 
> Index: src/pkg/regexp/exec2_test.go
> ===================================================================
> new file mode 100644
> --- /dev/null
> +++ b/src/pkg/regexp/exec2_test.go
> @@ -0,0 +1,20 @@
> +// Copyright 2013 The Go Authors. All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +// +build !race
> +
> +package regexp
> +
> +import (
> +    "testing"
> +)
> +
> +// This test is excluded when running under the race detector because
> +// it is a very expensive test and takes too long.
> +func TestRE2Exhaustive(t *testing.T) {
> +    if testing.Short() {
> +        t.Skip("skipping TestRE2Exhaustive during short test")
> +    }
> +    testRE2(t, "testdata/re2-exhaustive.txt.bz2")
> +}
> Index: src/pkg/regexp/exec_test.go
> ===================================================================
> --- a/src/pkg/regexp/exec_test.go
> +++ b/src/pkg/regexp/exec_test.go
> @@ -67,13 +67,6 @@
>    testRE2(t, "testdata/re2-search.txt")
> }
> 
> -func TestRE2Exhaustive(t *testing.T) {
> -    if testing.Short() {
> -        t.Skip("skipping TestRE2Exhaustive during short test")
> -    }
> -    testRE2(t, "testdata/re2-exhaustive.txt.bz2")
> -}
> -
> func testRE2(t *testing.T, file string) {
>    f, err := os.Open(file)
>    if err != nil {
> 
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
> 
> 

[dave_cheney.net, 2013-07-19 12:48:12]

LGTM. Please add

Update issue 5837

On Fri, Jul 19, 2013 at 7:28 PM, Dave Cheney <dave@cheney.net> wrote:
> Rémy also has a fix pending for this issue.
>
>
>
> On 19/07/2013, at 19:26, dsymonds@golang.org wrote:
>
>> Reviewers: golang-dev1,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go
>>
>>
>> Description:
>> regexp: exclude exhaustive RE2 test from running under race detector.
>>
>> It is an expensive test to run, and even more so with -race,
>> and causes timeouts on builders. It is doubtful that it would
>> find a race that other tests in this package wouldn't, so there
>> is little loss in excluding it.
>>
>> Please review this at https://codereview.appspot.com/11568043/
>>
>> Affected files:
>>  A src/pkg/regexp/exec2_test.go
>>  M src/pkg/regexp/exec_test.go
>>
>>
>> Index: src/pkg/regexp/exec2_test.go
>> ===================================================================
>> new file mode 100644
>> --- /dev/null
>> +++ b/src/pkg/regexp/exec2_test.go
>> @@ -0,0 +1,20 @@
>> +// Copyright 2013 The Go Authors. All rights reserved.
>> +// Use of this source code is governed by a BSD-style
>> +// license that can be found in the LICENSE file.
>> +
>> +// +build !race
>> +
>> +package regexp
>> +
>> +import (
>> +    "testing"
>> +)
>> +
>> +// This test is excluded when running under the race detector because
>> +// it is a very expensive test and takes too long.
>> +func TestRE2Exhaustive(t *testing.T) {
>> +    if testing.Short() {
>> +        t.Skip("skipping TestRE2Exhaustive during short test")
>> +    }
>> +    testRE2(t, "testdata/re2-exhaustive.txt.bz2")
>> +}
>> Index: src/pkg/regexp/exec_test.go
>> ===================================================================
>> --- a/src/pkg/regexp/exec_test.go
>> +++ b/src/pkg/regexp/exec_test.go
>> @@ -67,13 +67,6 @@
>>    testRE2(t, "testdata/re2-search.txt")
>> }
>>
>> -func TestRE2Exhaustive(t *testing.T) {
>> -    if testing.Short() {
>> -        t.Skip("skipping TestRE2Exhaustive during short test")
>> -    }
>> -    testRE2(t, "testdata/re2-exhaustive.txt.bz2")
>> -}
>> -
>> func testRE2(t *testing.T, file string) {
>>    f, err := os.Open(file)
>>    if err != nil {
>>
>>
>> --
>>
>> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>

[dsymonds, 2013-07-19 13:44:31]

*** Submitted as https://code.google.com/p/go/source/detail?r=c2eb7db7c980 ***

regexp: exclude exhaustive RE2 test from running under race detector.

It is an expensive test to run, and even more so with -race,
and causes timeouts on builders. It is doubtful that it would
find a race that other tests in this package wouldn't, so there
is little loss in excluding it.

Update issue 5837.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/11568043