Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(50)

Issue 115660043: code review 115660043: runtime: remove type.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by dvyukov
Modified:
10 years, 9 months ago
Reviewers:
rsc
CC:
golang-codereviews, rsc, iant, khr
Visibility:
Public.

Description

runtime: remove type.go We have an autogenerated version in zruntime_defs. I am not sure what are the consequences as gdb never printed any values for me. But it looks unnecessary to manually duplicate it.

Patch Set 1 #

Patch Set 2 : diff -r 333b975e98c2 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 333b975e98c2 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 0f83c90b799e https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -65 lines) Patch
M src/cmd/ld/dwarf.c View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/type.h View 2 chunks +2 lines, -7 lines 0 comments Download
R src/pkg/runtime/type.go View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-codereviews@googlegroups.com (cc: iant@golang.org, khr@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 9 months ago (2014-08-05 17:10:21 UTC) #1
rsc
NOT LGTM cmd/ld/dwarf.c looks for type.runtime.rtype, among other things. It needs these. Russ
10 years, 9 months ago (2014-08-05 17:42:51 UTC) #2
dvyukov
On Tue, Aug 5, 2014 at 9:42 PM, Russ Cox <rsc@golang.org> wrote: > NOT LGTM ...
10 years, 9 months ago (2014-08-05 17:59:41 UTC) #3
rsc
LGTM Oh, I missed that you updated ld. Fine.
10 years, 9 months ago (2014-08-05 18:09:25 UTC) #4
dvyukov
10 years, 9 months ago (2014-08-05 18:32:28 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=d92c94097e78 ***

runtime: remove type.go
We have an autogenerated version in zruntime_defs.
I am not sure what are the consequences as gdb never printed any values for me.
But it looks unnecessary to manually duplicate it.

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews, iant, khr
https://codereview.appspot.com/115660043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b