testing/checkers: fix Satisfies

testing/checkers: fix Satisfies

It didn't work when called with a nil argument.
A reflect gotcha to remember.

https://code.launchpad.net/~rogpeppe/juju-core/345-fix-satisfies-checker/+merge/176229

(do not edit description out of merge proposal)

[rog, 2013-07-22 15:41:51]

Please take a look.

[mue, 2013-07-22 15:47:04]

LGTM, nice check.

[dimitern, 2013-07-22 17:07:58]

LGTM with a couple of suggestions below.

https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go
File testing/checkers/bool_test.go (right):

https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go#...
testing/checkers/bool_test.go:54: arg: 41,
I'd prefer explicit result: false here and in other tests below, just to make it
easier to read.

https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go#...
testing/checkers/bool_test.go:69: f:      func(chan int) bool { return true },
Likewise, arg: nil here and below.

[dimitern, 2013-07-22 17:07:58]

LGTM with a couple of suggestions below.

https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go
File testing/checkers/bool_test.go (right):

https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go#...
testing/checkers/bool_test.go:54: arg: 41,
I'd prefer explicit result: false here and in other tests below, just to make it
easier to read.

https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go#...
testing/checkers/bool_test.go:69: f:      func(chan int) bool { return true },
Likewise, arg: nil here and below.

[rog, 2013-07-22 17:29:43]

Please take a look.

https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go
File testing/checkers/bool_test.go (right):

https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go#...
testing/checkers/bool_test.go:54: arg: 41,
On 2013/07/22 17:07:58, dimitern wrote:
> I'd prefer explicit result: false here and in other tests below, just to make
it
> easier to read.

Done.

https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go#...
testing/checkers/bool_test.go:69: f:      func(chan int) bool { return true },
On 2013/07/22 17:07:58, dimitern wrote:
> Likewise, arg: nil here and below.

Done.

[rog, 2013-07-22 17:30:45]

Please take a look.