Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(462)

Issue 11560044: testing/checkers: fix Satisfies

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by rog
Modified:
6 years, 3 months ago
Reviewers:
mue, mp+176229, dimitern
Visibility:
Public.

Description

testing/checkers: fix Satisfies It didn't work when called with a nil argument. A reflect gotcha to remember. https://code.launchpad.net/~rogpeppe/juju-core/345-fix-satisfies-checker/+merge/176229 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : testing/checkers: fix Satisfies #

Patch Set 3 : testing/checkers: fix Satisfies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -26 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M testing/checkers/bool.go View 1 chunk +24 lines, -3 lines 0 comments Download
M testing/checkers/bool_test.go View 1 1 chunk +62 lines, -23 lines 0 comments Download

Messages

Total messages: 6
rog
Please take a look.
6 years, 3 months ago (2013-07-22 15:41:51 UTC) #1
mue
LGTM, nice check.
6 years, 3 months ago (2013-07-22 15:47:04 UTC) #2
dimitern
LGTM with a couple of suggestions below. https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go File testing/checkers/bool_test.go (right): https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go#newcode54 testing/checkers/bool_test.go:54: arg: 41, ...
6 years, 3 months ago (2013-07-22 17:07:58 UTC) #3
dimitern
LGTM with a couple of suggestions below. https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go File testing/checkers/bool_test.go (right): https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go#newcode54 testing/checkers/bool_test.go:54: arg: 41, ...
6 years, 3 months ago (2013-07-22 17:07:58 UTC) #4
rog
Please take a look. https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go File testing/checkers/bool_test.go (right): https://codereview.appspot.com/11560044/diff/1/testing/checkers/bool_test.go#newcode54 testing/checkers/bool_test.go:54: arg: 41, On 2013/07/22 17:07:58, ...
6 years, 3 months ago (2013-07-22 17:29:43 UTC) #5
rog
6 years, 3 months ago (2013-07-22 17:30:45 UTC) #6
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b