Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(268)

Issue 11543043: Docs update for viewlets.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by matthew.scott
Modified:
10 years, 9 months ago
Reviewers:
rharding, mp+175676, benjamin.saller
Visibility:
Public.

Description

Docs update for viewlets. Docs now discuss viewlets defined in other files. https://code.launchpad.net/~makyo/juju-gui/viewlet-docs/+merge/175676 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Docs update for viewlets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -18 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M docs/index.rst View 1 chunk +1 line, -1 line 0 comments Download
M docs/viewlets.rst View 1 1 chunk +26 lines, -17 lines 0 comments Download

Messages

Total messages: 4
matthew.scott
Please take a look.
10 years, 9 months ago (2013-07-18 20:44:10 UTC) #1
rharding
LGTM with one addition request please. https://codereview.appspot.com/11543043/diff/1/docs/viewlets.rst File docs/viewlets.rst (right): https://codereview.appspot.com/11543043/diff/1/docs/viewlets.rst#newcode123 docs/viewlets.rst:123: template: Templates['show_units_small'], can ...
10 years, 9 months ago (2013-07-18 20:56:31 UTC) #2
benjamin.saller
LGTM but I'd change the example as mentioned https://codereview.appspot.com/11543043/diff/1/docs/viewlets.rst File docs/viewlets.rst (right): https://codereview.appspot.com/11543043/diff/1/docs/viewlets.rst#newcode128 docs/viewlets.rst:128: var ...
10 years, 9 months ago (2013-07-18 21:10:56 UTC) #3
matthew.scott
10 years, 9 months ago (2013-07-18 21:25:56 UTC) #4
*** Submitted:

Docs update for viewlets.

Docs now discuss viewlets defined in other files.

R=rharding, benjamin.saller
CC=
https://codereview.appspot.com/11543043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b