Issue 11540043: Charm dir perms in core #1202772

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11540043: Charm dir perms in core #1202772

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by matthew.scott

Modified:
10 years, 9 months ago

Reviewers:
mp+175649, benjamin.saller, gary.poster

Visibility:
Public.

Description

Charm dir perms in core #1202772 Apache was giving a 403 when charm was deployed using core due to perms on the charm dir. https://code.launchpad.net/~makyo/charms/precise/juju-gui/core-chmod/+merge/175649 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Charm dir perms in core #1202772 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	hooks/backend.py	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	revision	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

LGTM with trivial. Thank you! Gary https://codereview.appspot.com/11540043/diff/1/hooks/backend.py File hooks/backend.py (right): https://codereview.appspot.com/11540043/diff/1/hooks/backend.py#newcode153 hooks/backend.py:153: utils.cmd_log(shelltoolbox.run('chmod', '+x', utils.CURRENT_DIR)) ...

10 years, 9 months ago (2013-07-18 18:59:10 UTC) #3

matthew.scott

10 years, 9 months ago (2013-07-18 19:05:41 UTC) #4

*** Submitted:

Charm dir perms in core #1202772

Apache was giving a 403 when charm was deployed using core due to perms on the
charm dir.

R=benjamin.saller, gary.poster
CC=
https://codereview.appspot.com/11540043

Expand All Messages | Collapse All Messages