code review 11537044: net: remove unnecessary bit masking

net: remove unnecessary bit masking

[mikio, 2013-07-22 08:30:27]

Hello dave@cheney.net (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dfc, 2013-07-22 10:36:53]

LGTM.

On Mon, Jul 22, 2013 at 6:30 PM,  <mikioh.mikioh@gmail.com> wrote:
> Reviewers: dfc,
>
> Message:
> Hello dave@cheney.net (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net: remove unnecessary bit masking
>
> Please review this at https://codereview.appspot.com/11537044/
>
> Affected files:
>   M src/pkg/net/ipraw_test.go
>
>
> Index: src/pkg/net/ipraw_test.go
> ===================================================================
> --- a/src/pkg/net/ipraw_test.go
> +++ b/src/pkg/net/ipraw_test.go
> @@ -266,7 +266,7 @@
>         s = s + s>>16
>         // Place checksum back in header; using ^= avoids the
>         // assumption the checksum bytes are zero.
> -       b[2] ^= byte(^s & 0xff)
> +       b[2] ^= byte(^s)
>         b[3] ^= byte(^s >> 8)
>         return b, nil
>  }
> @@ -309,8 +309,8 @@
>  // reply message body p.
>  func (p *icmpEcho) Marshal() ([]byte, error) {
>         b := make([]byte, 4+len(p.Data))
> -       b[0], b[1] = byte(p.ID>>8), byte(p.ID&0xff)
> -       b[2], b[3] = byte(p.Seq>>8), byte(p.Seq&0xff)
> +       b[0], b[1] = byte(p.ID>>8), byte(p.ID)
> +       b[2], b[3] = byte(p.Seq>>8), byte(p.Seq)
>         copy(b[4:], p.Data)
>         return b, nil
>  }
>
>

[mikio, 2013-07-22 11:09:08]

*** Submitted as https://code.google.com/p/go/source/detail?r=5c948e69f885 ***

net: remove unnecessary bit masking

R=dave
CC=golang-dev
https://codereview.appspot.com/11537044