Issue 115350043: code review 115350043: undo CL 101460043 / 746e175af5d2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 115350043: code review 115350043: undo CL 101460043 / 746e175af5d2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by mikio

Modified:
9 years, 9 months ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

undo CL 101460043 / 746e175af5d2 preparing for the syscall package freeze. ««« original CL description syscall: add source-specific multicast socket options for Darwin Update issue 8266 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://codereview.appspot.com/101460043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 6125ea2b1dbf https://code.google.com/p/go #

Patch Set 3 : diff -r ea9ab79af1a4 https://code.google.com/p/go #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -71 lines)			Patch
M	src/pkg/syscall/types_darwin.go	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	src/pkg/syscall/zerrors_darwin_386.go	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/pkg/syscall/zerrors_darwin_amd64.go	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/pkg/syscall/ztypes_darwin_386.go	View	3 chunks	+0 lines, -22 lines	0 comments	Download
M	src/pkg/syscall/ztypes_darwin_amd64.go	View	3 chunks	+0 lines, -22 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 9 months ago (2014-07-29 14:09:00 UTC) #1

mikio

9 years, 9 months ago (2014-07-30 00:25:46 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=3f1d9609033c ***

undo CL 101460043 / 746e175af5d2

preparing for the syscall package freeze.

««« original CL description
syscall: add source-specific multicast socket options for Darwin

Update issue 8266

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/101460043
»»»

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/115350043

Expand All Messages | Collapse All Messages